! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
The screen is not dimmed anymore on log out dialog
Status:
RESOLVED: FIXED
Product:
Xfce4-session
Component:
General

Comments

Description Andre Miranda editbugs 2017-08-19 21:22:50 CEST
On log out dialog, the screen used to be dimmed, not anymore on 4.13.
Comment 1 Viktor Odintsev editbugs 2017-12-05 14:20:12 CET
There are a few problems with this part of xfsm.

For the first it incorrectly checks for a11y. For some reason it doesn't work with GTK 3 but it's not hard to fix since xfsm controls a11y startup and has a boolean field for this to check.

But proper checking of a11y is not enough. After this check xfsm tries to grab the keyboard and it fails. This should be fixed too.

And the third problem is that GdkWindow was changed so old code to dim a screen doesn't work. I rewrote this part with Xlib API.

I pushed all changes to user repo. https://git.xfce.org/users/ninetls/xfce4-session/log/?h=logout-dialog

Also I slightly edited the style of dialog so its paddings were like on GTK 2.

===========

Xfsm doesn't work well with multiple screens. Logout dialog works with GdkScreen instances too but this part of code is not correct. I haven't changed it. Xfsm should either support multiple screens (which is annoying with GDK 3) or work only with default screen as GDK does.
Comment 2 Eric Koegel editbugs 2017-12-07 08:06:29 CET
Thanks! Pushed to master in:

commit 1be6d6a24dd295016780c7c97100d4500aadad65 (HEAD -> master, origin/master, origin/HEAD)
Author: Viktor Odintsev <ninetls@xfce.org>
Date:   Tue Dec 5 16:03:47 2017 +0300

    Fix fadeout window using Xlib API
    
    Windows with override_redirect == TRUE have a different behavior
    starting with GDK 3. This part of code was rewritten with Xlib API.
    
    Signed-off-by: Eric Koegel <eric.koegel@gmail.com>
https://git.xfce.org/xfce/xfce4-session/commit/?id=1be6d6a24dd295016780c7c97100d4500aadad65

commit 62c7ed5a56c31e6dd89861605dbbd0162eada663
Author: Viktor Odintsev <ninetls@xfce.org>
Date:   Tue Dec 5 15:17:43 2017 +0300

    Fix keyboard grab for logout window
    
    Signed-off-by: Eric Koegel <eric.koegel@gmail.com>
https://git.xfce.org/xfce/xfce4-session/commit/?id=62c7ed5a56c31e6dd89861605dbbd0162eada663

commit 8a2733e822d5f0bae89027194aa0678a5b72a9c7
Author: Viktor Odintsev <ninetls@xfce.org>
Date:   Tue Dec 5 02:33:47 2017 +0300

    Check accessibility depending on xfsm configuration
    
    Signed-off-by: Eric Koegel <eric.koegel@gmail.com>
https://git.xfce.org/xfce/xfce4-session/commit/?id=8a2733e822d5f0bae89027194aa0678a5b72a9c7

commit 480cf90a0ac659457df36a5d11f7250159651ac4
Author: Viktor Odintsev <ninetls@xfce.org>
Date:   Tue Dec 5 03:13:37 2017 +0300

    Bump GTK version to 3.20
    
    Signed-off-by: Eric Koegel <eric.koegel@gmail.com>
https://git.xfce.org/xfce/xfce4-session/commit/?id=480cf90a0ac659457df36a5d11f7250159651ac4
Comment 3 Andre Miranda editbugs 2018-09-07 02:57:28 CEST
It's been fixed since a while, we just forgot to close.

Bug #13801

Reported by:
Andre Miranda
Reported on: 2017-08-19
Last modified on: 2018-09-07

People

Assignee:
Xfce Bug Triage
CC List:
4 users

Version

Version:
4.13.0

Attachments

Additional information