! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Use GtkBindingSet's instead of manual key press handling
Status:
CLOSED: FIXED
Severity:
enhancement

Comments

Description Benedikt Meurer editbugs 2006-01-25 22:15:21 CET
Several widgets (e.g. ThunarPropertiesDialog) should use GtkBindingSet's instead
of overriding key_press_event.
Comment 1 Benedikt Meurer editbugs 2006-01-30 22:56:46 CET
The easiest way would be to introduce an abstract widget class
ThunarAbstractDialog, which handles the binding set and derive all dialog
classes in Thunar from this class.
Comment 2 Benedikt Meurer editbugs 2006-02-14 23:59:06 CET
Committed with revision 19881.

2006-02-14	Benedikt Meurer <benny@xfce.org>

	* thunar/thunar-abstract-dialog.{c,h}, thunar/Makefile.am: Add new
	  abstract class ThunarAbstractDialog, which overrides GtkDialog::close
	  and provides additional keybindings for the "close" action. Bug #1380.
	* thunar/thunar-chooser-dialog.c, thunar/thunar-create-dialog.c,
	  thunar/thunar-location-dialog.c, thunar/thunar-preferences-dialog.c,
	  thunar/thunar-properties-dialog.c: Derive from ThunarAbstractDialog,
	  so all dialogs/windows in Thunar can be closed using the same
	  keyboard shortcuts and people can customize these shortcuts using
	  the standard GtkBindingSet mechanism. Bug #1380.

Bug #1380

Reported by:
Benedikt Meurer
Reported on: 2006-01-25
Last modified on: 2009-07-17

People

Assignee:
Jannis Pohlmann
CC List:
0 users

Version

Version:
0.2.1svn

Attachments

Additional information