! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Request confirmation when closing terminal with a open program
Status:
RESOLVED: FIXED
Product:
Xfce4-terminal
Component:
General

Comments

Description Agustin Ferrari 2017-08-15 06:38:30 CEST
The program should ask for confirmation to close a window or tab while a process is running, something that would be useful to avoid accidentally closing a terminal that has Midnight Commander open or an SSH session.
Looking in the mate-terminal source code (which has this functionality) I discovered that it calls the function terminal_screen_has_foreground_process[1] in confirm_close_window_or_tab[2].

[1]: http://git.mate-desktop.org/mate-terminal/tree/src/terminal-screen.c#n2271
[2]: http://git.mate-desktop.org/mate-terminal/tree/src/terminal-window.c#n3503
Comment 1 Igor editbugs 2017-08-15 15:02:52 CEST
Hi, this is a good idea indeed, thanks. I will look into it.
Comment 2 Git Bot editbugs 2017-08-17 15:07:38 CEST
Igor referenced this bugreport in commit 17dafe40dc89f0e69b774f4af9ef8e121a7acdb1

Request confirmation when closing the window while a process is running

https://git.xfce.org/apps/xfce4-terminal/commit?id=17dafe40dc89f0e69b774f4af9ef8e121a7acdb1
Comment 3 Igor editbugs 2017-08-17 15:08:05 CEST
Implemented.

Bug #13781

Reported by:
Agustin Ferrari
Reported on: 2017-08-15
Last modified on: 2017-08-17

People

CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information