! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Additional check for Clutter backend
Status:
RESOLVED: FIXED
Priority:
Very High
Product:
Xfdashboard
Component:
General

Comments

Description Olivier Duchateau 2017-08-09 17:52:25 CEST
Created attachment 7253 
Check if Clutter contains GDK backend

Since the 0.7.3 release, there are 2 backends ("x11" and "gdk"). Unfortunately on FreeBSD, Clutter does not provide GDK backend, so build fails. I suggest additional check in order to verify if clutter-gdk-1.0 exists or not.

As I'm not sure if gdk/window-tracker-backend-gdk.h header is really necessary, it is outside of conditional test in libxfdashboard/Makefile (in FreeBSD there is no -devel packages like Linux distribution).

Note: NetBSD seems also impacted (not OpenBSD).
Comment 1 Stephan Haller editbugs 2017-09-14 08:46:56 CEST
Created attachment 7316 
Check if Clutter contains GDK backend

Still checks if Clutter provides the GDK backend at target system but defines a macro HAVE_BACKEND_GDK at config.h and autotools variable GDK was renamed to XFDASHBOARD_BUILD_WITH_BACKEND_GDK.

This patch also modifies libxfdashboard/window-tracker-backend.c to include GDK header files only if macro HAVE_BACKEND_GDK was set by autotools configure script.
Comment 2 Stephan Haller editbugs 2017-09-14 08:47:42 CEST
Hi,

thanks for your patch. I was not aware that FreeBSD has not Clutter GDK backend. That's sad although the GDK backend in xfdashboard is not very different to the X11 backend except for the stage (main) window creation and handling.

With your patch you have already done the work I had next on my list ;) Thanks for that too.

But I also have two issues with it:

1.) Naming of the macro indicating if the GDK backend is available or not. Instead of naming it just plain "GDK" it would prefer "HAVE_BACKEND_GDK".

2.) You're right. The header file gdk/window-tracker-backend-gdk.h should only be included at window-tracker-backend.c if HAVE_BACKEND_GDK is defined.

I have adjusted your patch. Could you review it and test if it still works for you?
Comment 3 Olivier Duchateau 2017-09-14 20:49:09 CEST
Your patch works fine tested on my FreeBSD system.
Comment 4 Stephan Haller editbugs 2017-09-15 10:48:56 CEST
Great. It's in git now with commit 003f345967c3b17004213a3289e2b68339d6221b

Closing this bug report.

Thanks
Comment 5 Git Bot editbugs 2017-09-15 11:01:27 CEST
Stephan Haller referenced this bugreport in commit 003f345967c3b17004213a3289e2b68339d6221b

Additional check for Clutter backend

https://git.xfce.org/apps/xfdashboard/commit?id=003f345967c3b17004213a3289e2b68339d6221b

Bug #13766

Reported by:
Olivier Duchateau
Reported on: 2017-08-09
Last modified on: 2017-09-15

People

Assignee:
Stephan Haller
CC List:
0 users

Version

Version:
unspecified

Attachments

Check if Clutter contains GDK backend (2.34 KB, patch)
2017-08-09 17:52 CEST , Olivier Duchateau
no flags
Check if Clutter contains GDK backend (3.66 KB, patch)
2017-09-14 08:46 CEST , Stephan Haller
no flags

Additional information