! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] Documented UID fix
Status:
RESOLVED: FIXED
Product:
Xfce4-taskmanager
Component:
General

Comments

Description bobbyhopere 2017-08-06 11:07:33 CEST
Created attachment 7252 
UID documented patch

Cannot reopen this bug report so opening new one: https://bugzilla.xfce.org/show_bug.cgi?id=12970

RECAP: The reason why the first patch was proposed was because some programs start as root and later change to a different effective UID. Unbound is an example of such program. This was previously incorrectly reported as root by taskmanager.

The patch that was already committed apparently fixes the issue but using a non-documented method. My patch fixes the issue as described in "man proc". (The UID is extracted by parsing /proc/*/status not by using stat() on /proc/*/task). Also, my patch can easily be extended to also report other UIDs besides the "effective" UID: real, effective, saved set, and filesystem UIDs. That is up to the taskmanager developers to implement because I don't know GTK.

See attached patch.
Comment 1 Landry Breuil editbugs 2018-06-22 10:40:35 CEST
I think your patch was commited in https://git.xfce.org/apps/xfce4-taskmanager/commit/?id=946be336114ed84ad5d24838b4ae14a0bfc0f0fe, closing this bug.

Bug #13764

Reported by:
bobbyhopere
Reported on: 2017-08-06
Last modified on: 2018-06-22

People

Assignee:
Mike Massonnet
CC List:
1 user

Version

Version:
unspecified

Attachments

UID documented patch (1.41 KB, patch)
2017-08-06 11:07 CEST , bobbyhopere
no flags

Additional information