! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
SIGSEGV when thumbnailer is under heavy load after opening many tabs
Status:
RESOLVED: FIXED

Comments

Description Daniel Reichelt 2017-07-31 20:24:56 CEST
Created attachment 7249 
fix (see bug desc)

Analyzing the coredump I assume this happened due to invalid access to job->thumbnailer. I guess the _thunar_return_if_fail() checks a few lines down should happen earlier.

Unfortunately, I don't have a reliable way of reproducing the issue in order to check whether the attached patch is a valid fix.

Cheers
Daniel
Comment 1 alexxcons editbugs 2018-02-28 22:03:11 CET
Thanks for the patch and sorry for the late reply !

Looks like these "return_if_fail" checks really are misplaced. So even if this should not fix the SIGSEGV, imo it is a good idea to apply the patch.

I will do so for master and xfce-4.12 branch
Comment 2 Git Bot editbugs 2018-02-28 22:04:14 CET
Daniel Reichelt referenced this bugreport in commit 67102a81fd87d9fc32c6e457fe0a5fc23a97f31d

SIGSEGV when thumbnailer is under heavy load after opening many tabs (bug #13756)

https://git.xfce.org/xfce/thunar/commit?id=67102a81fd87d9fc32c6e457fe0a5fc23a97f31d
Comment 3 Git Bot editbugs 2018-02-28 22:15:50 CET
Daniel Reichelt referenced this bugreport in commit 31b96783edc74b9e716ce1c9d63cb0ede0a4300d

SIGSEGV when thumbnailer is under heavy load after opening many tabs (bug #13756)

https://git.xfce.org/xfce/thunar/commit?id=31b96783edc74b9e716ce1c9d63cb0ede0a4300d

Bug #13756

Reported by:
Daniel Reichelt
Reported on: 2017-07-31
Last modified on: 2018-02-28

People

Assignee:
Xfce Bug Triage
CC List:
3 users

Version

Version:
1.6.11

Attachments

fix (see bug desc) (1.10 KB, patch)
2017-07-31 20:24 CEST , Daniel Reichelt
no flags

Additional information