! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Calling xfce_dialog_show_help() crashes app
Status:
RESOLVED: FIXED
Product:
Libxfce4ui
Component:
General

Comments

Description Ali Akcaagac 2017-07-05 16:22:57 CEST
I am using xfce4-terminal (git) and detected an reproducable issue which leads into xfce4-terminal crashes.

1) Please open xfce4-terminal
2) Add another Tab
3) Double click on the tab
4) Now a "bubble" kind of entering box pops up
5) You are presented with an "bubble", an input field, a question mark and a "x"
6) Click on the question mark .... crash


Btw: The question mark should be labeled "Help" and not "_Help". In case this may be the issue.
Comment 1 Igor editbugs 2017-07-05 16:35:29 CEST
Though you're right about "_Help" label, this shouldn't be causing the crash.

I cannot reproduce the crash here - a new "Online Documentation" dialog opens for me. Can you try Help->Contents - does it crash the terminal for you?
Comment 2 Ali Akcaagac 2017-07-05 16:48:08 CEST
Interestingly yes it crashes...

Crashes also if I do the same in Panel Help ... Screenshoter Help ... It basicly nails off the Programs instantly...

Could it be some helper libraries used ? like libxfce4ui or libxfce4util ?
Comment 3 Ali Akcaagac 2017-07-05 16:49:06 CEST
Created attachment 7221 
coredump.txt

Ok I don't habe any debugsymbols installed now... But I am having lack of time as of now... Maybe this helps meanwhile... Will come back to that soon...
Comment 4 Igor editbugs 2017-07-05 16:53:52 CEST
(In reply to Ali Akcaagac from comment #2)
> Interestingly yes it crashes...
> 
> Crashes also if I do the same in Panel Help ... Screenshoter Help ... It
> basicly nails off the Programs instantly...
> 
> Could it be some helper libraries used ? like libxfce4ui or libxfce4util ?

Yes, it seems to be crashing within libxfce4ui:
                #5  0x00007ff92a899474 xfce_message_dialog_new_valist (libxfce4ui-2.so.0)
                #6  0x00007ff92a899bab xfce_message_dialog_new (libxfce4ui-2.so.0)
                #7  0x00007ff92a89a5dc xfce_dialog_show_help_with_version (libxfce4ui-2.so.0)

What version of libxfce4ui are you using? Can you try reinstalling it?
Comment 5 Ali Akcaagac 2017-07-05 17:11:40 CEST
libxfce4ui-devel-4.13.2-1.fc26.x86_64

Compiled by me and RPM packaged...

But I noticed that there is 4.13.3 already out... Including this patch...

https://git.xfce.org/xfce/libxfce4ui/commit/?id=e3c255de0b38be5eb92cfaf3ef7243b2c4817dc6

I am not sure whether this may be related... But I just installed the debuginfo and devel packs as well and will trash the panel now :)

Edit: Ok also trashed the terminal again. Looks like both panel and terminal are calling the same function within the libxfce4ui 4.13.2 release. I am still not sure whether above commit fixes it (or if it's yet another issue).

Sadly if you open 10 terminals and one crashes then all are gone :(
Comment 6 Ali Akcaagac 2017-07-05 17:12:03 CEST
Created attachment 7222 
coredump-panel.txt
Comment 7 Ali Akcaagac 2017-07-05 17:14:08 CEST
Created attachment 7223 
coredump-terminal.txt
Comment 8 Ali Akcaagac 2017-07-05 17:27:29 CEST
Without further investigation into the issue...

But the "w" and "h" variables are quite interesting... If they are representatives for "w = width" and "h = height" then I can assure, that the "pixmap" dimensions are insane ;)

Even negative values seem to be there...
Comment 9 Igor editbugs 2017-07-05 22:28:37 CEST
(In reply to Ali Akcaagac from comment #8)
> Without further investigation into the issue...
> 
> But the "w" and "h" variables are quite interesting... If they are
> representatives for "w = width" and "h = height" then I can assure, that the
> "pixmap" dimensions are insane ;)
> 
> Even negative values seem to be there...

w and h values are fine since the variables are just declared but not initialized yet which means they've taken unused memory and have garbage values.
Comment 10 Igor editbugs 2017-07-05 22:50:06 CEST
Can you try libxfce4ui 4.13.3?
Comment 11 Igor editbugs 2017-07-06 00:49:18 CEST
4.13.3 does not make it any better.
Transferring the bug to libxfce4ui as this is their bug.

(xfce4-terminal:10590): Gtk-ERROR **: failed to add UI: The resource at “/org/xfce/libxfce4ui/libxfce4ui-dialog-ui.ui” does not exist
Trace/breakpoint trap (core dumped)

Jul 05 18:44:47 systemd-coredump[10597]: Process 10590 (xfce4-terminal) of user 1000 dumped core.
                                         Stack trace of thread 10590:
                                         #0  0x00007f171f722401 n/a (libglib-2.0.so.0)
                                         #1  0x00007f171f724a51 g_log_writer_default (libglib-2.0.so.0)
                                         #2  0x00007f171f722f9e g_log_structured_array (libglib-2.0.so.0)
                                         #3  0x00007f171f723297 g_log_structured (libglib-2.0.so.0)
                                         #4  0x00007f1720fc1f93 gtk_builder_new_from_resource (libgtk-3.so.0)
                                         #5  0x00007f17217a3a3c xfce_message_dialog_new_valist (libxfce4ui-2.so.0)
                                         #6  0x00007f17217a3fcb xfce_message_dialog_new (libxfce4ui-2.so.0)
                                         #7  0x00007f17217a49dc xfce_dialog_show_help_with_version (libxfce4ui-2.so.0)
Comment 12 Eric Koegel editbugs 2017-07-18 13:31:37 CEST
Created attachment 7231 
Attempt to fix missing gresource file

Can you try out this patch? It reverts back to generating a header file as well as the c file. Maybe the linker was stripping out the c file that had the ui resource?
Comment 13 Igor editbugs 2017-07-18 14:45:51 CEST
Hi Eric, this patch seems to fix the issue, thanks!
Comment 14 Git Bot editbugs 2017-07-18 17:20:12 CEST
Eric Koegel referenced this bugreport in commit abc5144ad8ed42eaf4256facf395e8df97a6535c

Attempt to fix missing gresource file (Bug #13705)

https://git.xfce.org/xfce/libxfce4ui/commit?id=abc5144ad8ed42eaf4256facf395e8df97a6535c
Comment 15 Eric Koegel editbugs 2017-07-19 04:58:40 CEST
Thanks for testing, marking closed.
Comment 16 Ali Akcaagac 2017-07-21 08:54:01 CEST
Confirming... Works... Thanks!
Comment 17 Skunnyk editbugs 2017-10-19 11:55:16 CEST
*** Bug 13888 has been marked as a duplicate of this bug. ***
Comment 18 Skunnyk editbugs 2017-11-22 13:14:30 CET
*** Bug 14020 has been marked as a duplicate of this bug. ***

Bug #13705

Reported by:
Ali Akcaagac
Reported on: 2017-07-05
Last modified on: 2017-11-22
Duplicates (2):
  • 13888 Removing a panel does not work
  • 14020 xfce4-panel crashes when attempting to remove selected panel

People

Assignee:
Eric Koegel
CC List:
6 users

Version

Version:
4.13.3

Attachments

coredump.txt (13.99 KB, text/plain)
2017-07-05 16:49 CEST , Ali Akcaagac
no flags
coredump-panel.txt (13.72 KB, text/plain)
2017-07-05 17:12 CEST , Ali Akcaagac
no flags
coredump-terminal.txt (16.58 KB, text/plain)
2017-07-05 17:14 CEST , Ali Akcaagac
no flags
Attempt to fix missing gresource file (2.32 KB, patch)
2017-07-18 13:31 CEST , Eric Koegel
no flags

Additional information