! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Thunar writes broken XML declaratation into uca.xml
Status:
RESOLVED: FIXED

Comments

Description Yann Büchau 2017-06-06 09:11:54 CEST
Thunar keeps writing a broken XML declaration into the user uca.xml custom actions file. According to https://www.w3.org/TR/xml/#NT-XMLDecl, the version='1.0' should be the first thing after the <?xml, not the encoding='UTF-8'.


Steps to reproduce:

1) delete your custom actions file (rm ~/.config/Thunar/uca.xml)
2) Open Thunar, go to Edit -> Custom Actions and double click any of the pre-defined actions or create a new one, then click OK.
3) now check the newly created uca.xml XML declaration (head -1 ~/.config/Thunar/uca.xml). It says:

<?xml encoding="UTF-8" version="1.0"?>

This broken XML declaration may prevent some XML parsers from correctly parsing the uca.xml file.

I'm on Xubuntu 16.04.

Further information:

> locale
LANG=de_DE.UTF-8
LANGUAGE=de_DE:en_GB:en
LC_CTYPE="de_DE.UTF-8"
LC_NUMERIC=de_DE.UTF-8
LC_TIME=de_DE.UTF-8
LC_COLLATE="de_DE.UTF-8"
LC_MONETARY=de_DE.UTF-8
LC_MESSAGES="de_DE.UTF-8"
LC_PAPER=de_DE.UTF-8
LC_NAME=de_DE.UTF-8
LC_ADDRESS=de_DE.UTF-8
LC_TELEPHONE=de_DE.UTF-8
LC_MEASUREMENT=de_DE.UTF-8
LC_IDENTIFICATION=de_DE.UTF-8
LC_ALL=

> dpkg -s thunar
Package: thunar
Status: install ok installed
Priority: optional
Section: xfce
Installed-Size: 890
Maintainer: Xubuntu Developers <xubuntu-devel@lists.ubuntu.com>
Architecture: amd64
Version: 1.6.11-0ubuntu0.16.04.1
Replaces: thunar-data (<< 1.2.3-3)
Depends: libatk1.0-0 (>= 1.12.4), libc6 (>= 2.4), libcairo2 (>= 1.6.0), libdbus-1-3 (>= 1.9.14), libdbus-glib-1-2 (>= 0.88), libexo-1-0 (>= 0.10.0), libgdk-pixbuf2.0-0 (>= 2.22.0), libglib2.0-0 (>= 2.37.3), libgtk2.0-0 (>= 2.24.0), libgudev-1.0-0 (>= 146), libice6 (>= 1:1.0.0), libnotify4 (>= 0.7.0), libpango-1.0-0 (>= 1.14.0), libsm6, libthunarx-2-0 (>= 1.1.0), libxfce4ui-1-0 (>= 4.9.1), libxfce4util7 (>= 4.9.0), libxfconf-0-2 (>= 4.6.0), thunar-data (= 1.6.11-0ubuntu0.16.04.1), desktop-file-utils, shared-mime-info, exo-utils
Recommends: dbus-x11, xfce4-panel (>= 4.11), xfce4-panel (<< 4.13), thunar-volman, tumbler, xdg-user-dirs, gvfs
Suggests: thunar-archive-plugin, thunar-media-tags-plugin
Breaks: thunar-data (<< 1.2.3-3)
Description: File Manager for Xfce
 Thunar is the file manager designed to be the default file manager for the
 Xfce desktop environment. It has been designed to be fast and easy to use.
 .
 Also included is an Xfce panel plugin which can manage the desktop trash.
Homepage: http://thunar.xfce.org
Original-Maintainer: Debian Xfce Maintainers <pkg-xfce-devel@lists.alioth.debian.org>
Comment 1 Theo Linkspfeifer editbugs 2019-07-07 23:27:33 CEST
Created attachment 8737 
patch
Comment 2 Git Bot editbugs 2019-07-09 22:52:59 CEST
Theo Linkspfeifer referenced this bugreport in commit 95985bb3acd99d3a5ce5d002e9a842f0d3f0cc76

Fix XML declaratation in uca.xml (Bug #13623)

https://git.xfce.org/xfce/thunar/commit?id=95985bb3acd99d3a5ce5d002e9a842f0d3f0cc76
Comment 3 Git Bot editbugs 2019-07-09 22:54:36 CEST
Theo Linkspfeifer referenced this bugreport in commit c480ee7b8f2c26e09dcdd4f4bed240c4d1123e42

Fix XML declaratation in uca.xml (Bug #13623)

https://git.xfce.org/xfce/thunar/commit?id=c480ee7b8f2c26e09dcdd4f4bed240c4d1123e42
Comment 4 alexxcons editbugs 2019-07-09 22:59:36 CEST
.. you are digging on old bugs ? :D

IMO the order of the xml attributes theoretically should not matter (As far as I can see the linked 23.org website does not say that "version" has to be first)

However there realy may exist some xml parsers out there which require the version to be the first attribute :)

Bug #13623

Reported by:
Yann Büchau
Reported on: 2017-06-06
Last modified on: 2019-07-09

People

Assignee:
Xfce Bug Triage
CC List:
5 users

Version

Version:
1.6.11

Attachments

patch (921 bytes, patch)
2019-07-07 23:27 CEST , Theo Linkspfeifer
no flags

Additional information