! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
v-blank wait is done twice
Status:
RESOLVED: FIXED

Comments

Description spaz16 2017-06-01 21:50:35 CEST
Created attachment 7144 
Patch

I've noticed performance drop since https://github.com/xfce-mirror/xfwm4/commit/7115d1b4f4021043bb59e6acafa105cb77fe5b9d - I no longer can disable it.

We have "glXSwapBuffers()" (since https://github.com/xfce-mirror/xfwm4/commit/fee08eafa751a153ff93b04152ea66334141cac5) which waits for v-blank (if enabled in driver), so any other "synthetic" waiting for v-blank can reduce performance (de-sync) and does nothing else (tested - if vsync is disabled in driver, the old code doesn't fully prevent tearing).

Patch is attached :)

In another patch we could use e.g. "glXSwapIntervalMESA" or "glXSwapIntervalSGI" to force-enable swap interval in driver.
Comment 1 Olivier Fourdan editbugs 2017-06-02 08:55:45 CEST
I was kinda expecting this, so I agree :)
Comment 2 Olivier Fourdan editbugs 2017-06-02 09:00:27 CEST
I amended the commit message slightly and pushed to git master as commit b2c7463.

Thanks!
Comment 3 Olivier Fourdan editbugs 2017-06-02 09:01:17 CEST
Closing.

Bug #13613

Reported by:
spaz16
Reported on: 2017-06-01
Last modified on: 2017-06-02

People

Assignee:
Olivier Fourdan
CC List:
0 users

Version

Version:
unspecified

Attachments

Patch (4.03 KB, patch)
2017-06-01 21:50 CEST , spaz16
no flags

Additional information