! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
The icon in the xfce (vertical) panel can shrink to a dot (too much absolute ...
Status:
RESOLVED: FIXED
Product:
Xfce4-whiskermenu-plugin
Component:
General

Comments

Description 0ld3r0q68r3 2017-06-01 13:29:09 CEST
Created attachment 7141 
screen capture (vertical)

Please test (try) the whisker menu with vertical, rather thin (20 pixels) panel too.

Experience is that the icon "disappears" (becomes a dot).
Possibly because of the (left and right) padding of the icon.
Comment 1 0ld3r0q68r3 2017-06-01 13:31:12 CEST
Created attachment 7142 
screen capture (horizontal)
Comment 2 0ld3r0q68r3 2017-06-01 13:31:38 CEST
The version is
xfce4-whiskermenu-plugin  2.1.1-0ubuntu1  amd64
Comment 3 Graeme Gott editbugs 2017-06-02 14:45:41 CEST
There is no absolute padding. *All* padding come from GTK. If you use a different theme (such as Greybird), or you switch to the GTK3 panel (which is still in development, true), then the icon is not a dot on a vertical 20px panel. There really isn't much I can do differently, sorry.
Comment 4 0ld3r0q68r3 2017-06-02 16:40:01 CEST
Please, at least give some idea, where to try to post this issue.

Regarding the themes: there is no any change. In Appearance, changing either the "style" or the "icons" (icon set), the Whisker icon remains microscopical.

All other icons resize good, only the whisker do not.
Comment 5 Graeme Gott editbugs 2017-06-02 17:18:05 CEST
Did you restart the panel or log out and log back in after changing the theme? I have found that Whisker Menu does not properly change size until you do one of those things after switching themes. On my computer in Arch Linux, Greybird doesn't have the excess padding, so the icon is larger.

The other icons are launchers on a GTK2 panel, so they are GTK2 buttons. Whisker Menu 2.1.1 is a GTK3 button, so it has larger padding. The extra padding is out of my control.
Comment 6 Git Bot editbugs 2017-10-18 13:23:54 CEST
Graeme Gott referenced this bugreport in commit f8cfe65b6017768e1ad559b336b517c6e60d30c3

Fix excessive padding on panel button. (bug #13611)

https://git.xfce.org/panel-plugins/xfce4-whiskermenu-plugin/commit?id=f8cfe65b6017768e1ad559b336b517c6e60d30c3
Comment 7 Graeme Gott editbugs 2017-10-18 13:30:20 CEST
After investigating the source code of the GTK3 panel, I discovered that I actually can override the padding to fix this issue.
Comment 8 twilightinzero 2018-05-14 15:56:02 CEST
So I see that you fixed this issue that I started having when I moved from Xubuntu 16.04 to 18.04, but it looks like your fixes adjusted some undesirable hard limits on the icon size that I don't think were present in the GTK2 version. Specifically, it looks like your code clamps the icon size depending on the widget size. This breaks my setup, and probably some others too. I put x/ythickness at 0 on all panel widgets for GTK2, and now the equivalent fix isn't working here. I couldn't figure out why, but looking at that specific commit explained it for me. Here's what my panel looks like: https://imgur.com/UnIedHo

If I use the GTK3 inspector, I can change the icon size and it looks fine. Other GTK3 panel widgets, like the status notifier, look fine too. I don't know what they do to set the icon size. I thought I could just rip out the icon size setting code entirely and have it work, but the icon is oversized if I do that, so I just hardcoded mine to be panel size - 2. It looks like the 4.13 path is to do it intelligently using a given API call, but Bionic doesn't have 4.13 or that API.

That makes me wonder, how did it always "just work" in the GTK2 version, and now it doesn't anymore?

Bug #13611

Reported by:
0ld3r0q68r3
Reported on: 2017-06-01
Last modified on: 2018-05-14

People

Assignee:
Graeme Gott
CC List:
1 user

Version

Attachments

screen capture (vertical) (2.36 KB, image/png)
2017-06-01 13:29 CEST , 0ld3r0q68r3
no flags
screen capture (horizontal) (2.69 KB, image/png)
2017-06-01 13:31 CEST , 0ld3r0q68r3
no flags

Additional information