! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Thunar symlink leftover on make uninstall
Status:
RESOLVED: FIXED

Comments

Description Andre Miranda editbugs 2017-04-27 16:32:21 CEST
Steps to reproduce:
./configure # let prefix as /usr/local
make
sudo make install
sudo make uninstall

Expected results:
All thunar files removed from prefix

Actual results:
A leftover: /usr/local/bin/Thunar (broken symlink to /usr/local/bin/thunar)

Probably due this (thunar/Makefile.am:285):
# install symlink to 'thunar'
install-exec-hook:
	$(mkinstalldirs) $(DESTDIR)$(bindir)
	-( cd $(DESTDIR)$(bindir) ; test -x Thunar || ln -sf thunar Thunar )
Comment 1 Andre Miranda editbugs 2017-04-27 16:34:39 CEST
I mean, the install-exec-hook is not wrong, just that there's no "uninstall-exec-hook", I don't even know if this is available in autotools sorcery.
Comment 2 Andre Miranda editbugs 2017-05-03 05:04:23 CEST
Created attachment 7097 
Proposed patch

Here is the patch, it works here®
Comment 3 flocculant 2017-05-03 13:14:06 CEST
It works here too ...
Comment 4 Git Bot editbugs 2017-09-24 00:03:18 CEST
Andre Miranda referenced this bugreport in commit 0265c0ff809517f6e3b2208447a67e5160a661dd

Delete Thunar symlink on uninstall (Bug #13533)

https://git.xfce.org/xfce/thunar/commit?id=0265c0ff809517f6e3b2208447a67e5160a661dd
Comment 5 Git Bot editbugs 2017-09-24 00:03:41 CEST
Andre Miranda referenced this bugreport in commit 634df2302a979ce8af39e8fffe9980929b2fe945

Delete Thunar symlink on uninstall (Bug #13533)

https://git.xfce.org/xfce/thunar/commit?id=634df2302a979ce8af39e8fffe9980929b2fe945
Comment 6 Andre Miranda editbugs 2017-09-24 00:04:23 CEST
Closing...

Bug #13533

Reported by:
Andre Miranda
Reported on: 2017-04-27
Last modified on: 2017-09-24

People

Assignee:
Xfce Bug Triage
CC List:
3 users

Version

Version:
1.6.11

Attachments

Proposed patch (696 bytes, patch)
2017-05-03 05:04 CEST , Andre Miranda
no flags

Additional information