Created attachment 7091 patch Subj. Looks like nicer and implementation is smaller :) Check it out. terminal/terminal-window.c | 49 +++++++++---------------------------------------- 1 file changed, 9 insertions(+), 40 deletions(-)
Hi Alexander, Thanks for the patch! However, I don't really like how it looks without tab bar... Could you please try to move the popover "anchor point" to make it look nicer?
hey Igor, how can I run terminal without tabs to test that? thanks
Alexander, you have to set MiscAlwaysShowTabs option to false in your config, and start terminal window with a single tab.
In fact, I'm not sure about the whole thing... For example, gnome-terminal seems to have implemented search dialog as a popover but then reverted it back (and I agree with their reasons): commit 9b18c48ccb591d157cf38511219bbf27fde0bad2 (tag: 3.19.90) Author: Christian Persch <chpe@gnome.org> Date: Tue Feb 16 18:59:09 2016 +0100 search: Revert to using a window instead of a popover The popover isn't movable and might cover the match, so until that can be fixed, revert to using a window for the search dialogue. https://bugzilla.gnome.org/show_bug.cgi?id=755653
Oh wait, we're talking about set title dialog here. Then I guess it won't hurt much if it covers some terminal contents. Anyway, were you able to work on patch improvement, Alexander?
correct, it's a set title small window replacement. But seems there is no api to relocate popover to the center of the widget. right now you can put popover on top,bottom,left or right of some gtkwidget. So for now I have no idea how to put gtkpopover in the middle of the screen as its been before.
Created attachment 7158 new versio thats my best shot. In no menubar case Im attaching a popover to the menubar. Looks pretty good, check it out.
Hi Alexander, The latest version looks really good, indeed! I've merged your patch and improved the popover a bit. Thank you!