! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Preferences window opens over 1400px wide
Status:
RESOLVED: FIXED
Product:
Xfce4-terminal
Component:
General

Comments

Description Mariusz 2017-04-14 12:40:16 CEST
Created attachment 7075 
Screenshot showing my #1 suspect

Hello. Terminal Preferences windows always opens over 1400px wide even when I closed it much smaller before. This issue occurred after upgrading Xubuntu from 16.10 to 17.04, so I think it's related with switching GTK2 to GTK3.

I think the information text on top of the 'Compatibility' tab may be responsible for this, because when I make the window smaller the text there doesn't have word-wrapping. So maybe this text frame forces the window to open wide to show whole information? Maybe it occurs only in my language translation? (Polish)

I attached screenshot.
Comment 1 Igor editbugs 2017-04-14 15:21:05 CEST
Hi Mariusz. Thanks for the report!
You're right, this happens because of Polish translation - the long text string should contain a couple of new line chars ('\n') which would break it down into 3 shorter strings. I will try to contact the translator and ask him to fix this.
Comment 2 Mariusz 2017-04-14 15:50:10 CEST
Thanks. I'm glad I could help somehow.

My humble suggestion:
Poniższe opcje mogą powodować nieprawidłowe działanie niektórych programów.\n
Zostały one udostępnione tylko po to, aby umożliwić pracę z pewnymi programami\n
i systemami operacyjnymi, które oczekują nieco innego zachowania terminala.

PS: Seems like there's a double space between "udostępnione  tylko" in the translation string, but I can be wrong.
Comment 3 Andrzej editbugs 2017-04-14 18:07:24 CEST
Created attachment 7076 
Proposed fix to the preferences dialog layout

The patch (first commit) limits the label width to max 80 characters and fixes this bug.
The second commit removes manual line breaks from the untranslated label (optional).
Comment 4 Igor editbugs 2017-04-14 23:16:38 CEST
String fixed on transifex.
Comment 5 Igor editbugs 2017-04-15 15:15:00 CEST
Andrzej, I've merged your 1st patch, thanks!

Bug #13497

Reported by:
Mariusz
Reported on: 2017-04-14
Last modified on: 2017-04-15

People

CC List:
2 users

Version

Attachments

Additional information