! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
build: Incorrect use of AC_ARG_ENABLE for --enable-pathchecks
Status:
RESOLVED: FIXED
Product:
Xfce4-sensors-plugin
Component:
General

Comments

Description Michał Górny 2017-04-04 19:11:35 CEST
The usage of AC_ARG_ENABLE is roughly:

  AC_ARG_ENABLE(name, help, if-provided, if-not-provided)

i.e. the third argument gets executed if either --enable-foo or --disable-foo is passed, and the fourth if neither.

The new code states:

    AC_ARG_ENABLE([pathchecks], [AC_HELP_STRING([--enable-pathchecks], [Enable checks for paths, access and execution @<:@default=yes@:>@])],
    [
        NETCAT_RUN=skip
    ], [
        AC_MSG_CHECKING([for hddtemp being queryable via netcat])
        NETCAT_RUN=([`"$NETCAT_PATH" "$NETCAT_HOST" "$HDDTEMP_PORT" 2> /dev/null`])
        AC_MSG_RESULT([$NETCAT_RUN])
    ])

i.e. the checks will be skipped both with --enable-pathchecks and --disable-pathchecks, and run only if neither is passed. I don't think that's what you wanted.
Comment 1 Fabian Nowak editbugs 2017-04-04 20:11:20 CEST
Thanks, obviously I was no longer aware of that. Fixed in Git with commit 5823443.
Comment 2 Fabian Nowak editbugs 2017-04-06 23:51:06 CEST
.

Bug #13478

Reported by:
Michał Górny
Reported on: 2017-04-04
Last modified on: 2017-04-06

People

Assignee:
Fabian Nowak
CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information