! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Can''t execute higher debug levels, due to Compiler Warnings


Description rickstockton@reno-computerhelp.com 2017-04-03 21:17:00 CEST
Due to my use of very recent software packages in openSUSE "Tumbleweed", Xfwm4 (and it's related binaries) cannot be compiled with "DEBUG" set high enough to execute "TRACE" calls.

un-supressed warnings occur within "workspace-settings.c", "client.c", "compositor.c", "icons.c", and "keyboard.c".

Some appear to be very easy fixes, but I have no idea how to re-code our use of deprecated "gdk_pixbuf_New_from_inline".
Comment 1 rickstockton@reno-computerhelp.com 2017-04-03 21:25:31 CEST
I'm using using 4.12 tarfile version 2017-03-26.

  CC       xfwm4_workspace_settings-workspace-settings.o
workspace-settings.c: In function ‘workspace_dialog_configure_widgets’:
workspace-settings.c:318:5: warning: ‘gdk_pixbuf_new_from_inline’ is deprecated [-Wdeprecated-declarations]
     monitor = gdk_pixbuf_new_from_inline (-1, monitor_icon_data, TRUE, NULL);

  CC       xfwm4-client.o
client.c: In function ‘clientApplyMWMHints’:
client.c:979:19: warning: unused variable ‘mwm_hints’ [-Wunused-variable]
     PropMwmHints *mwm_hints;

  CC       xfwm4-compositor.o
compositor.c: In function ‘check_gl_error’:
compositor.c:1022:6: warning: this ‘while’ clause does not guard... [-Wmisleading-indentation]
      while (error != GL_NO_ERROR);
compositor.c:1023:6: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘while’

  CC       xfwm4-icons.o
icons.c: In function ‘inline_icon_at_size’:
icons.c:77:5: warning: ‘gdk_pixbuf_new_from_inline’ is deprecated [-Wdeprecated-declarations]
     base = gdk_pixbuf_new_from_inline (-1, data, FALSE, NULL);

  CC       xfwm4-keyboard.o
keyboard.c: In function ‘parseKeyString’:
keyboard.c:139:31: warning: pointer targets in passing argument 2 of ‘getModifierMap’ differ in signedness [-Wpointer-sign]
     if (!getModifierMap (str, &key->modifier))
keyboard.c:90:1: note: expected ‘guint * {aka unsigned int *}’ but argument is of type ‘int *’

  CC       xfwm4-placement.o
placement.c: In function ‘clientKeepVisible’:
placement.c:474:17: warning: variable ‘screen_info’ set but not used [-Wunused-but-set-variable]
     ScreenInfo *screen_info;
Comment 2 Olivier Fourdan editbugs 2017-04-04 08:35:32 CEST
As you noted, some of those are unlikely to be fixed because they have to do with deprecation in GdkPixbuf.

The real problem is compiling with -Werror, we should not do that but this is not coming from xfwm4.
Comment 3 Git Bot editbugs 2020-05-29 12:16:02 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfwm4/-/issues/257.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #13475

Reported by:
Reported on: 2017-04-03
Last modified on: 2020-05-29


Olivier Fourdan
CC List:
1 user




Additional information