Here is the full error: cc1: warnings being treated as errors thunar-vfs-xfer.c: In function 'thunar_vfs_xfer_next_path': thunar-vfs-xfer.c:221: warning: implicit declaration of function 'ngettext' thunar-vfs-xfer.c:221: warning: passing argument 1 of 'g_strdup_printf' makes po inter from integer without a cast thunar-vfs-xfer.c:223: warning: passing argument 1 of 'g_strdup_printf' makes po inter from integer without a cast Being compiled on an Ubuntu Breezy 5.10 PPC box. All required dependencies are installed, and only cairo of the optional ones. Reproducible: Always Steps to Reproduce:
Created attachment 404 Fix for missing ngettext declaration Please try this patch. Thanks.
(In reply to comment #0) > Here is the full error: > > cc1: warnings being treated as errors > thunar-vfs-xfer.c: In function 'thunar_vfs_xfer_next_path': > thunar-vfs-xfer.c:221: warning: implicit declaration of function 'ngettext' > thunar-vfs-xfer.c:221: warning: passing argument 1 of 'g_strdup_printf' makes po > inter from integer without a cast > thunar-vfs-xfer.c:223: warning: passing argument 1 of 'g_strdup_printf' makes po > inter from integer without a cast > > Being compiled on an Ubuntu Breezy 5.10 PPC box. All required dependencies are > installed, and only cairo of the optional ones. > > Reproducible: Always > Steps to Reproduce: (In reply to comment #1) > Created an attachment (id=404) [edit] > Fix for missing ngettext declaration > > Please try this patch. Thanks. Patch seems to fix the previous error, but now I get a new error: --- cc1: warnings being treated as errors thunar-launcher.c: In function 'thunar_launcher_open_paths': thunar-launcher.c:381: warning: implicit declaration of function 'ngettext' thunar-launcher.c:381: warning: passing argument 1 of 'g_strdup_printf' makes po inter from integer without a cast thunar-launcher.c: In function 'thunar_launcher_open_new_windows': thunar-launcher.c:492: warning: passing argument 2 of 'gtk_message_dialog_format _secondary_text' makes pointer from integer without a cast thunar-launcher.c: In function 'thunar_launcher_update': thunar-launcher.c:548: warning: passing argument 3 of 'g_snprintf' makes pointer from integer without a cast --- then after some more compiling: --- make[3]: *** [Thunar-thunar-launcher.o] Error 1 make[3]: *** Waiting for unfinished jobs.... cc1: warnings being treated as errors thunar-list-model.c: In function 'thunar_list_model_get_statusbar_text': thunar-list-model.c:1995: warning: implicit declaration of function 'ngettext' thunar-list-model.c:1995: warning: passing argument 1 of 'g_strdup_printf' makes pointer from integer without a cast thunar-list-model.c:2000: warning: passing argument 1 of 'g_strdup_printf' makes pointer from integer without a cast thunar-list-model.c:2042: warning: passing argument 1 of 'g_strdup_printf' makes pointer from integer without a cast thunar-list-model.c:2047: warning: passing argument 1 of 'g_strdup_printf' makes pointer from integer without a cast make[3]: *** [Thunar-thunar-list-model.o] Error 1 make[2]: *** [all] Error 2 make[2]: Leaving directory `/usr/src/Thunar-0.2.0alpha-r19548/thunar' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/usr/src/Thunar-0.2.0alpha-r19548' make: *** [all] Error 2 --- Let me know if you need any more information.
Created attachment 407 Next try Ok, this one should fix all missing ngettext() declarations.
*** Bug 1348 has been marked as a duplicate of this bug. ***
No more ngettext errors (with patch try #2 applied), but now receiving a new error: In file included from thunar-vfs-xfer.c:45: /usr/include/glib-2.0/glib/gi18n-lib.h:30:1: error: "_" redefined In file included from thunar-vfs-xfer.c:43: /usr/include/glib-2.0/glib/gi18n.h:25:1: error: this is the location of the previous definition In file included from thunar-vfs-xfer.c:45: /usr/include/glib-2.0/glib/gi18n-lib.h:31:1: error: "Q_" redefined In file included from thunar-vfs-xfer.c:43: /usr/include/glib-2.0/glib/gi18n.h:26:1: error: this is the location of the previous definition Thanks again...
I received the same messages initially... re-extracting the source and applying the patch again solved it for me. (I had applied the first patch earlier.) YMMV. M.
I just tried re-extracting the tarball and applying patch v2 (sorry, should have tried that in the first place). However, my luck seems to be pretty bad: (I apologize for the length, I don't know what is or isn't relevant...) --- In file included from /usr/include/xfce4/libxfce4util/i18n.h:42, from /usr/include/xfce4/libxfce4util/libxfce4util.h:34, from /usr/local/include/exo-0.3/exo/exo.h:32, from ../thunar-vfs/thunar-vfs-enum-types.h:6, from ../thunar-vfs/thunar-vfs.h:26, from ../thunar/thunar-metafile.h:23, from ../thunar/thunar-file.h:23, from ../thunar/thunar-folder.h:23, from ../thunar/thunar-window.h:23, from ../thunar/thunar-application.h:24, from thunar-launcher.c:26: /usr/include/glib-2.0/glib/gi18n-lib.h:30:1: error: "_" redefined In file included from thunar-launcher.c:24: /usr/include/glib-2.0/glib/gi18n.h:25:1: error: this is the location of the prev ious definition In file included from /usr/include/xfce4/libxfce4util/i18n.h:42, from /usr/include/xfce4/libxfce4util/libxfce4util.h:34, from /usr/local/include/exo-0.3/exo/exo.h:32, from ../thunar-vfs/thunar-vfs-enum-types.h:6, from ../thunar-vfs/thunar-vfs.h:26, from ../thunar/thunar-metafile.h:23, from ../thunar/thunar-file.h:23, from ../thunar/thunar-folder.h:23, from ../thunar/thunar-window.h:23, from ../thunar/thunar-application.h:24, from thunar-launcher.c:26: /usr/include/glib-2.0/glib/gi18n-lib.h:31:1: error: "Q_" redefined In file included from thunar-launcher.c:24: /usr/include/glib-2.0/glib/gi18n.h:26:1: error: this is the location of the prev ious definition In file included from /usr/include/xfce4/libxfce4util/i18n.h:42, from /usr/include/xfce4/libxfce4util/libxfce4util.h:34, from /usr/local/include/exo-0.3/exo/exo.h:32, from ../thunar-vfs/thunar-vfs-enum-types.h:6, from ../thunar-vfs/thunar-vfs.h:26, from ../thunar/thunar-metafile.h:23, from ../thunar/thunar-file.h:23, from ../thunar/thunar-folder.h:23, from ../thunar/thunar-list-model.h:23, from thunar-list-model.c:33: /usr/include/glib-2.0/glib/gi18n-lib.h:30:1: error: "_" redefined In file included from thunar-list-model.c:31: /usr/include/glib-2.0/glib/gi18n.h:25:1: error: this is the location of the prev ious definition In file included from /usr/include/xfce4/libxfce4util/i18n.h:42, from /usr/include/xfce4/libxfce4util/libxfce4util.h:34, from /usr/local/include/exo-0.3/exo/exo.h:32, from ../thunar-vfs/thunar-vfs-enum-types.h:6, from ../thunar-vfs/thunar-vfs.h:26, from ../thunar/thunar-metafile.h:23, from ../thunar/thunar-file.h:23, from ../thunar/thunar-folder.h:23, from ../thunar/thunar-list-model.h:23, from thunar-list-model.c:33: /usr/include/glib-2.0/glib/gi18n-lib.h:31:1: error: "Q_" redefined In file included from thunar-list-model.c:31: /usr/include/glib-2.0/glib/gi18n.h:26:1: error: this is the location of the prev ious definition
Which version of Xfce do you use?
4.2.2 (packages from ubuntu breezy). is this what's causing the problem?
Maybe, I'm not yet sure what's the exact cause of the problem. I'll try to come up with a new patch.
Created attachment 420 Trying to fix it in libexo I'm still not sure what causes the initial problem, and I cannot reproduce it. Please recompile libexo with this patch, then revert the previous patch to Thunar (i.e. re-extract the tarball), and see if it fixes the problem.
Here's the error I get with libexo patched/recompiled, and Thunar patched: --- In file included from /usr/local/include/exo-0.3/exo/exo.h:32, from ../thunar-vfs/thunar-vfs-enum-types.h:6, from ../thunar-vfs/thunar-vfs.h:26, from ../thunar/thunar- metafile.h:23, from ../thunar/thunar-file.h:23, from ../thunar/thunar-folder.h:23, from ../thunar/thunar-window.h:23, from ../thunar/thunar-application.h :24, from thunar-launcher.c:26: /usr/include/glib-2.0/glib/gi18n-lib.h:30:1: error: "_" redefined In file included from thunar-launcher.c:24: /usr/include/glib-2.0/glib/gi18n.h:25:1: error: this is the location of the previous definition In file included from /usr/local/include/exo-0.3/exo/exo.h:32, from ../thunar-vfs/thunar-vfs-enum-types.h:6, from ../thunar-vfs/thunar-vfs.h:26, from ../thunar/thunar- metafile.h:23, from ../thunar/thunar-file.h:23, from ../thunar/thunar-folder.h:23, from ../thunar/thunar-window.h:23, from ../thunar/thunar-application.h :24, from thunar-launcher.c:26: /usr/include/glib-2.0/glib/gi18n-lib.h:31:1: error: "Q_" redefined In file included from thunar-launcher.c:24: /usr/include/glib-2.0/glib/gi18n.h:26:1: error: this is the location of the previous definition make[3]: *** [Thunar-thunar-launcher.o] Error 1 make[3]: Leaving directory `/usr/src/Thunar-0.2.0alpha-r19548/thunar' make[2]: *** [all] Error 2 make[2]: Leaving directory `/usr/src/Thunar-0.2.0alpha-r19548/thunar' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/usr/src/Thunar-0.2.0alpha-r19548' make: *** [all] Error 2
As said, don't apply the Thunar patch. Just patch libexo, but use the unpatched Thunar.
My apologies. Thunar compiles successfully with the libexo patch. I will let you close the bug : )
Fixed with revision 19611. 2006-01-25 Benedikt Meurer <benny@xfce.org> * exo/exo.h: Make sure i18n stuff is setup properly, so people with older Xfce versions can still build and run Thunar. This fixes bug #1341.