! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
copy selection to the clipboard not resistent to empty selection
Status:
RESOLVED: FIXED
Product:
Xfce4-terminal
Component:
General

Comments

Description Yves-Alexis Perez editbugs 2017-03-02 10:10:53 CET
Hi,

I got a report from a Debian user (https://bugs.debian.org/856456) that the “copy selection to clipboard” option was a bit broken.

When someone select something inside a terminal, that selection is correctly copied to the clipboard. However, when the application is quit, the selection is emptied, so the terminal_screen_vte_selection_changed() callback is called and the empty string is then copied to the clipboard, which is usually not the intended behavior.

Maybe it would make sense to ignore empty strings for the copy?
Comment 1 Igor editbugs 2017-03-02 11:40:48 CET
Hi, thanks for the report, I can reproduce the problem here.

A side note: you were not correct saying "it's a vte thing" - it's purely xfce4-terminal implementation.
Comment 2 Igor editbugs 2017-03-02 11:48:36 CET
This commit fixes it for me: https://git.xfce.org/apps/xfce4-terminal/commit/?id=924c27b55ff101115049e2359fa9ba56fd549cc6
Please verify the patch if possible.

Bug #13403

Reported by:
Yves-Alexis Perez
Reported on: 2017-03-02
Last modified on: 2017-03-02

People

CC List:
1 user

Version

Attachments

Additional information