Version 1.2.97 build fails with -Wl,--no-undefined linker flag. libtool: link: gcc -shared -Wl,--as-needed -fPIC -DPIC .libs/libxfce4sensors_la-middlelayer.o .libs/libxfce4sensors_la-configuration.o .libs/libxfce4sensors_la-sensors-interface-common.o .libs/libxfce4sensors_la-sensors-interface.o .libs/libxfce4sensors_la-tacho.o .libs/libxfce4sensors_la-lmsensors.o .libs/libxfce4sensors_la-hddtemp.o .libs/libxfce4sensors_la-acpi.o -pthread -pthread -pthread -pthread -O2 -g -fstack-protector -Wl,--as-needed -Wl,--no-undefined -Wl,-z -Wl,relro -Wl,-O1 -Wl,--build-id -Wl,--enable-new-dtags -Wl,--export-dynamic -pthread -pthread -lxfce4ui-2 -lxfce4panel-2.0 -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lgmodule-2.0 -lxfce4util -lsensors -lm -lnotify -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -Wl,-soname -Wl,libxfce4sensors.so.1 -Wl,-version-script -Wl,.libs/libxfce4sensors.ver -o .libs/libxfce4sensors.so.1.2.4 .libs/libxfce4sensors_la-sensors-interface.o: In function `add_type_box': /home/wally/mageia/xfce/xfce4-sensors-plugin/BUILD/xfce4-sensors-plugin-1.2.97/lib/sensors-interface.c:210: undefined reference to `sensor_entry_changed' .libs/libxfce4sensors_la-sensors-interface.o: In function `add_update_time_box': /home/wally/mageia/xfce/xfce4-sensors-plugin/BUILD/xfce4-sensors-plugin-1.2.97/lib/sensors-interface.c:246: undefined reference to `adjustment_value_changed' .libs/libxfce4sensors_la-sensors-interface.o: In function `add_sensor_settings_box': /home/wally/mageia/xfce/xfce4-sensors-plugin/BUILD/xfce4-sensors-plugin-1.2.97/lib/sensors-interface.c:277: undefined reference to `list_cell_text_edited' /home/wally/mageia/xfce/xfce4-sensors-plugin/BUILD/xfce4-sensors-plugin-1.2.97/lib/sensors-interface.c:295: undefined reference to `list_cell_toggle' /home/wally/mageia/xfce/xfce4-sensors-plugin/BUILD/xfce4-sensors-plugin-1.2.97/lib/sensors-interface.c:304: undefined reference to `list_cell_color_edited' /home/wally/mageia/xfce/xfce4-sensors-plugin/BUILD/xfce4-sensors-plugin-1.2.97/lib/sensors-interface.c:316: undefined reference to `minimum_changed' /home/wally/mageia/xfce/xfce4-sensors-plugin/BUILD/xfce4-sensors-plugin-1.2.97/lib/sensors-interface.c:333: undefined reference to `maximum_changed' .libs/libxfce4sensors_la-sensors-interface.o: In function `add_temperature_unit_box': /home/wally/mageia/xfce/xfce4-sensors-plugin/BUILD/xfce4-sensors-plugin-1.2.97/lib/sensors-interface.c:394: undefined reference to `temperature_unit_change' collect2: error: ld returned 1 exit status Makefile:533: recipe for target 'libxfce4sensors.la' failed
Confirmed. Due to insufficient knowledge of software techiques at that time. Will try to fix with the next release. Thanks for letting me know by running this harder test. Will also include the no-undefined flag in the debug mode in autogen/configure.
Commit 1d39804..15736f7 contains the fixes and extended debug checks for autoconf. Not the most beautiful solution, but it works for now and remains as an open issue for future.
Thanks for the fix. Please note that '-Wl,--no-undefined' should go to PLATFORM_LDFLAGS instead.
Whoops, you're absolutely right; I missed that there were the CFLAGS, that was unintended. Of cource, CFLAGS is not the appropriate place, but rather LDFLAGS. Committed with 69d98cf..079390c.