! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Unable to get performance statistics for devices with major number > 255


Description jlrdragon 2017-01-06 01:10:45 CET
The disk performance monitor will not display statistics for devices with a major number greater than 255, e.g. NVMe disk devices (major number 259), even when said devices are available in /proc/diskstats / /proc/partitions. The plugin instead generates a "Device statistics unavailable" message.
As of this writing (2017-01-06 00:10 UTC), reproducible on the latest version available from Ubuntu packages (2.5.5-1), and the version on the git tree.
Comment 1 Landry Breuil editbugs 2017-02-19 15:08:30 CET
Probably caused by this: https://git.xfce.org/panel-plugins/xfce4-diskperf-plugin/tree/panel-plugin/devperf.c#n62

Comment 2 Landry Breuil editbugs 2017-02-19 15:29:42 CET
Created attachment 7010 
tentative fix

Does it work if you try with this patch ?
Comment 3 Landry Breuil editbugs 2017-02-19 15:31:21 CET
(I of course dont have a linux to try it here)
Comment 4 jlrdragon 2017-02-19 23:07:42 CET
Just tried the patch - it seems to be working with the patch applied.
Comment 5 Landry Breuil editbugs 2017-02-20 08:31:37 CET
(In reply to jlrdragon from comment #4)
> Just tried the patch - it seems to be working with the patch applied.

Great ! But most importantly, does it still work for disk devices where the major is < 255 ? Just want to make sure it doesnt regress...
Comment 6 jlrdragon 2017-02-20 20:43:32 CET
It still reports stats for my /dev/sda, so, yes.
Comment 7 Landry Breuil editbugs 2017-02-20 20:58:44 CET
Thanks ! Applied in https://git.xfce.org/panel-plugins/xfce4-diskperf-plugin/commit/?id=a18919e4063f4f9c2947971d1c26fbf942a7a3c9 - should do a new release soonish.
Comment 8 thecatlover1996 2017-10-13 20:34:26 CEST
*** Bug 13588 has been marked as a duplicate of this bug. ***

Bug #13281

Reported by:
Reported on: 2017-01-06
Last modified on: 2017-10-13
Duplicates (1):
  • 13588 Measure disk performance on nvme SSD drive


Landry Breuil
CC List:
3 users




tentative fix (1.12 KB, patch)
2017-02-19 15:29 CET , Landry Breuil
no flags

Additional information