! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Shrinks when closing/opening tabs
Status:
RESOLVED: FIXED
Product:
Xfce4-terminal
Component:
General

Comments

Description Egmont Koblinger 2017-01-05 21:23:44 CET
Open three tabs, close the 3rd one. The height shrinks by 1 pixel (causing an almost complete unused line at the bottom). Open a 3rd tab again, the window further shrinks so this partial line vanishes. Repeat to shrink by one more line at each close+open pair.

Ubuntu Yakkety, default Unity7 Ambiance, vte @b517d20 I guess, xfce4-terminal @adeb89e.
Comment 1 Igor editbugs 2017-01-06 10:00:25 CET
Hi Egmont, I cannot reproduce this under Xfce on Arch. I'll have to install Ubuntu in a VM to check.

Does xfce4-terminal produce any messages when opening/closing tabs?
Does gnome-terminal also shrink?
Comment 2 Egmont Koblinger 2017-01-06 10:48:19 CET
Hi,

When closing the third tab (which results in a grid-disobeying size) this is printed twice:

(xfce4-terminal:12345): Gtk-WARNING **: Allocating size to GtkScrollbar 0x5640944e33e0 without calling gtk_widget_get_preferred_width/height(). How does the code know the size to allocate?

g-t does not suffer from this bug. It does not print this warning on opening/closing tabs, but does on manual resizes (and so does xfce4-terminal. I've also seen this message from many other apps. It must be some generic Gtk+ f.ckup I guess).
Comment 3 Igor editbugs 2017-01-06 10:59:52 CET
(In reply to Egmont Koblinger from comment #2)
> g-t does not suffer from this bug. It does not print this warning on
> opening/closing tabs, but does on manual resizes (and so does
> xfce4-terminal. I've also seen this message from many other apps. It must be
> some generic Gtk+ f.ckup I guess).

Yes, it must be a f.ckup :) https://bugzilla.gnome.org/show_bug.cgi?id=769566. And it seems to be resolved in Gtk 3.22.

I was able to reproduce your issue in Ubuntu 16.10. Interestingly, it's not reproducible in 16.04 so I'm thinking it could be a Gtk (3.18.9 in 16.04 vs 3.20.19 in 16.10) or Unity (7.4 vs 7.5) issue.
I will try Ubuntu Zesty which has Gtk 3.22.5 and see if the issue is reproducible.
Comment 4 Egmont Koblinger 2017-01-06 11:02:44 CET
Okay, if it's fixed in newer Gtk+ then there's probably nothing you should do. I'll upgrade to zesty when the final beta comes out at the end of March.
Comment 5 Igor editbugs 2017-01-06 11:11:30 CET
Well, I've tried Zesty, and the GtkScrollbar size issue is gone but the shrinking issue still remains. I'll look into it further.

BTW, do you know why vte is not showing its geometry (rows x columns) when resizing under Unity?
Comment 6 Egmont Koblinger 2017-01-06 11:15:58 CET
VTE never shows its geometry, the window manager does (if does).

You need to install an additional package, compiz-plugins-extra if I remember correctly, but maybe a different one; and also install compizconfig-settings-manager. Then enable ccsm -> Utility -> Resize info.
Comment 7 Egmont Koblinger 2017-01-06 11:18:07 CET
compiz-plugins-extra is an empty package, it's probably compiz-plugins[-whatever].
Comment 8 Igor editbugs 2017-01-06 11:46:23 CET
Ok, thanks for the info.
Comment 9 Igor editbugs 2017-01-08 17:54:47 CET
I was able to resolve this issue by removing a set_window_geometry_hints() call. Egmont, please confirm this fixed the issue for you as well: https://git.xfce.org/apps/xfce4-terminal/commit/?id=4528cc08dd0d1c8c9191c3f98abba463fea5a91a
Comment 10 Egmont Koblinger 2017-01-08 21:00:48 CET
Yup, confirmed. Thanks a lot! :)

Bug #13280

Reported by:
Egmont Koblinger
Reported on: 2017-01-05
Last modified on: 2017-01-08

People

Assignee:
Nick Schermer
CC List:
1 user

Version

Attachments

Additional information