! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
assertion failure when renaming files
Status:
RESOLVED: FIXED

Comments

Description Christoph Pfister 2016-12-29 18:08:01 CET
Created attachment 6939 
gdb stacktrace

(Thunar 1.6.10git-45fb3a15)

An assertion failure (stack trace attached) can be triggered reliably by navigating thunar to a folder containing the script 'exercise.py' and running that script (which randomly creates and renames files to check whether file system events are handled correctly).

Error analysis (thunar-folder.c):

1) thunar_folder_reload starts a new job and returns

2) thunar_folder_content_type_loader is called from a different context and sets content_type_idle_id

3) thunar_folder_finished is called when the job finishes and causes the failure because content_type_idle_id != 0

Goodie:

I will also attach a stack trace for step 2 in case this helps (obtained by adding a check for folder->job == NULL in thunar_folder_content_type_loader).

It's certainly easy to provide workarounds but I don't understand the logic well enough to provide a proper fix.

Cheers,

Christoph
Comment 1 Christoph Pfister 2016-12-29 18:09:00 CET
Created attachment 6940 
stack trace for step 2
Comment 2 Christoph Pfister 2016-12-29 18:10:53 CET
Created attachment 6941 
script for stress testing
Comment 3 Skunnyk editbugs 2017-06-02 22:53:12 CEST
Can you try with Thunar 1.6.11 ? (https://mail.xfce.org/pipermail/xfce-announce/2017-February/000495.html) Tons of bugs has been fixed in this release.
Comment 4 Christoph Pfister 2017-06-03 13:14:10 CEST
Created attachment 7154 
1.6.11git-f5221396 stacktrace A
Comment 5 Christoph Pfister 2017-06-03 13:15:16 CEST
Created attachment 7155 
1.6.11git-f5221396 stacktrace B
Comment 6 Christoph Pfister 2017-06-03 13:15:29 CEST
Created attachment 7156 
1.6.11git-f5221396 stacktrace C
Comment 7 Christoph Pfister 2017-06-03 13:18:05 CEST
I've obtained the three attached stacktraces (distinct, but related) with 1.6.11git-f5221396.
Comment 8 Christoph Pfister 2017-06-10 12:16:17 CEST
The attached stacktraces for 1.6.11 only exist because g_warning becomes fatal with '--enable-debug=full'; after removing that warning, I haven't been able to trigger any issue, so 1.6.11 seems to have fixed this bug.

Bug #13262

Reported by:
Christoph Pfister
Reported on: 2016-12-29
Last modified on: 2017-06-10

People

Assignee:
Xfce Bug Triage
CC List:
3 users

Version

Version:
1.6.10

Attachments

gdb stacktrace (3.99 KB, text/plain)
2016-12-29 18:08 CET , Christoph Pfister
no flags
stack trace for step 2 (4.54 KB, text/plain)
2016-12-29 18:09 CET , Christoph Pfister
no flags
script for stress testing (738 bytes, text/x-python)
2016-12-29 18:10 CET , Christoph Pfister
no flags
1.6.11git-f5221396 stacktrace A (3.69 KB, text/plain)
2017-06-03 13:14 CEST , Christoph Pfister
no flags
1.6.11git-f5221396 stacktrace B (6.84 KB, text/plain)
2017-06-03 13:15 CEST , Christoph Pfister
no flags
1.6.11git-f5221396 stacktrace C (8.69 KB, text/plain)
2017-06-03 13:15 CEST , Christoph Pfister
no flags

Additional information