the manual page says you can specify --data-composition or --audio-composition from the command line. the --data-composition option works as expected, however, the --audio-composition option opens both a data composition and an audio composition.
It works for me, -data-composition option open data composition, --audio-composition option open audio composition. Can you reproduce ?
the bug actually only occurs when you also specify multiple FILE paths, e.g.: xfburn --audio-composition "/home/itteffi/Music/song1.mp3" "/home/itteffi/Music/song2.mp3" if no FILE paths are specified, the bug will not reproduce; if a single FILE path is specified, it doesn't appear to be applicable, as you're brought immediately to the "Burn image" dialog; but if 2 or more FILE paths are specified, a data composition tab is opened in addition to an audio composition tab.
Ah, yes, good catch, I can reproduce. It's an expected behavior 'for now', see here : https://git.xfce.org/apps/xfburn/tree/xfburn/xfburn-main.c#n340 . So if someone is willing to implement the detection of audio track when passing multiple arguments… :)
@Skunnyk, the logic is wrong ... line 346 should be changed to: } else if (argc > 2 && !add_data_composition && !add_audio_composition) { the todo, "auto-detect music files for audio compositions", is only supposed to apply if the --audio-composition option wasn't specified; if the --audio-composition option is specified, obviously you don't need to guess the user's intention....
in addition to the above, which i'm pretty sure about, i'm not so sure that lines 343 and 346 should be comparing argc with 2 (as they are) instead of 1.
please disregard comment 5; http://crasseux.com/books/ctutorial/argc-and-argv.html says the command itself is considered an argument, so I believe 2 is the correct point of comparison.
Oh, yes, by changing line 346, the bug is fixed (it open only the audio compositor). Can you confirm ?
well, i'm not actually compiling (as i'm not doing any xfburn development), so I can't technically confirm the fix
Ok, so I confirm that the bug is fixed by this "patch". Thank you. I'll commit it to master.
Romain B referenced this bugreport in commit 6df73ec15e6b629d4bfbb8de81acbd24da554e09 Do no open data-composition when running --audio-composition https://git.xfce.org/apps/xfburn/commit?id=6df73ec15e6b629d4bfbb8de81acbd24da554e09