! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] Fix typo in exif tag for image height
Status:
RESOLVED: FIXED
Product:
Tumbler
Component:
General

Comments

Description Justin Gassner 2016-12-17 20:28:15 CET
Created attachment 6931 
[PATCH] Fix typo in exif tag for image height

In the file tumbler/plugins/ffmpeg-thumbnailer/ffmpeg-thumbnailer.c the if condition at line 500 matches the previous if condition at line 498:

498          if (tag == 0x0100)
499            exif->thumb.thumb_tiff.width = value;
500          else if (tag == 0x0100)
501            exif->thumb.thumb_tiff.height = value;

According to [1], Exif.Image.ImageLength (here called height) is tag 0x0101.

Found by cppcheck.

[1] http://www.exiv2.org/tags.html
Comment 1 Justin Gassner 2016-12-17 20:31:22 CET
Correction: The excerpt above is actually from the file
tumbler/plugins/jpeg-thumbnailer/jpeg-thumbnailer.c
Comment 2 Ali Abdallah editbugs 2017-05-29 20:09:11 CEST
Sorry for the delay, patch has been applied to git master and it will be included in the next release.

Bug #13240

Reported by:
Justin Gassner
Reported on: 2016-12-17
Last modified on: 2017-05-29

People

Assignee:
Ali Abdallah
CC List:
1 user

Version

Version:
unspecified

Attachments

Additional information