! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
"ä" character appears incorrect on changelog webpage
Status:
RESOLVED: MOVED
Severity:
enhancement
Product:
www.xfce.org
Component:
General

Comments

Description scootergrisen 2016-12-10 16:43:01 CET
https://xfce.org/download/changelogs/4.12:
The "ä" in "Jani Välimaa" appears incorrect twice on the webpage.
I will let other person decide the corret character.
Comment 1 scootergrisen 2016-12-10 16:44:26 CET
In www.xfce.org/lib/translators.php:
    'Gatis Kalniņš <> <Gatis Kalniņš' => '>',

Suggest correction to:
    'Gatis Kalniņš' => '',

Or ask "Gatis Kalniņš" is person want an e-mail on there.

An empty value still gives "<>" on the webpage so i suggest changing in file www.xfce.org/pages/about/credits.php:

    foreach ($people as $person => $mail)
    {
      echo $person.' &lt;'.mungify_mail($mail).'&gt;';

      if ($mail != $last)
        echo "<br />\n";
    }

To:

    foreach ($people as $person => $mail)
    {
      echo $person;

      if (!empty($mail))
        echo ' &lt;'.mungify_mail($mail).'&gt;';

      if ($mail != $last)
        echo "<br />\n";
    }

Maybe functions print_credits and print_translator_credits should go into one function instead of two as they seem to do almost the same.
Comment 2 scootergrisen 2016-12-10 16:46:07 CET
diff --git a/lib/translators.php b/lib/translators.php
index 5c312b6..caefdff 100644
--- a/lib/translators.php
+++ b/lib/translators.php
@@ -272,7 +272,7 @@ $translators = array (
     'Sung Jin Gang' => 'ujuc'.ATSIGN.'ujuc'.DOTSIGN.'kr',
   ),
   'Latvian [lv]' => array (
-    'Gatis Kalniņš <> <Gatis Kalniņš' => '>',
+    'Gatis Kalniņš' => '',
     'Rihards Prieditis' => 'rprieditis'.ATSIGN.'gmail'.DOTSIGN.'com',
   ),
   'Lithuanian [lt]' => array (
diff --git a/pages/about/credits.php b/pages/about/credits.php
index 0be73a8..c72cfd7 100644
--- a/pages/about/credits.php
+++ b/pages/about/credits.php
@@ -30,7 +30,10 @@ function print_translator_credits()
     $last = end ($people);
     foreach ($people as $person => $mail)
     {
-      echo $person.' &lt;'.mungify_mail($mail).'&gt;';
+      echo $person;
+
+      if (!empty($mail))
+        echo ' &lt;'.mungify_mail($mail).'&gt;';
 
       if ($mail != $last)
         echo "<br />\n";
diff --git a/pages/download/changelogs/4.8.php b/pages/download/changelogs/4.8.php
deleted file mode 100644
index 04360a7..0000000
Comment 3 Git Bot editbugs 2020-05-20 18:39:03 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/www/www.xfce.org/-/issues/2.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #13216

Reported by:
scootergrisen
Reported on: 2016-12-10
Last modified on: 2020-05-20

People

Assignee:
Skunnyk
CC List:
2 users

Version

Version:
unspecified

Attachments

Additional information