! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfmedia doesnt compile with dbus 0.60
Status:
RESOLVED: LATER
Product:
Xfmedia
Component:
general

Comments

Description Yves-Alexis Perez editbugs 2005-12-28 00:02:15 CET
I know xfmedia is frozen at the moment, but there will be a dbus transition in
debian, to dbus 0.60. I've tried to build xfmedia with dbus 0.60 and i get this
error:

remote.c: In function 'xfmedia_remote_init':
remote.c:493: error: 'DBUS_NAME_FLAG_PROHIBIT_REPLACEMENT' undeclared (first use
in this function)
remote.c:493: error: (Each undeclared identifier is reported only once
remote.c:493: error: for each function it appears in.)


Reproducible: Always
Steps to Reproduce:
1. 
2. 
3.
Comment 1 Brian J. Tarricone (not reading bugmail) 2006-01-01 15:24:06 CET
I'm getting rather tired of #ifdef'ing a bunch of crap to track slight
incompatibilities in dbus versions.  When 1.0 comes out I'll make it work with
that and drop support for all other versions.  Not too interested in fixing this
right now.
Comment 2 Yves-Alexis Perez editbugs 2006-01-07 13:24:32 CET
Hi Brian,

dbus 0.60 hit debian unstable yesterday, so we (xfce debian packagers) wanted to
patch xfmedia so it builds with it.

Jani Monoses made a patch for ubuntu which does:

-DBUS_NAME_FLAG_PROHIBIT_REPLACEMENT
+DBUS_NAME_FLAG_DO_NOT_QUEUE

in the code. (src/remote.c)

I've seen that, in remote.c, there is a #define:

#define DBUS_NAME_FLAG_PROHIBIT_REPLACEMENT DBUS_SERVICE_FLAG_PROHIBIT_REPLACEMENT

Maybe the patch sould only define:

#define DBUS_NAME_FLAG_PROHIBIT_REPLACEMENT DBUS_NAME_FLAG_DO_NOT_QUEUE

I know that you *don't* want another bunch of #ifdef, but this patch is only for
building with dbus 0.60.  Which solution would you recommend (if they are
correct..) ?
Comment 3 Brian J. Tarricone (not reading bugmail) 2006-02-23 19:54:46 CET
*** Bug 1495 has been marked as a duplicate of this bug. ***

Bug #1299

Reported by:
Yves-Alexis Perez
Reported on: 2005-12-28
Last modified on: 2006-02-23
Duplicates (1):
  • 1495 xfmedia-svn doesn't compile with dbus 0.60

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
1 user

Version

Attachments

Additional information