! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Xfce crashes when window title is too long
Status:
RESOLVED: FIXED

Comments

Description Jari Jokinen 2005-12-26 16:23:48 CET
Xfce 4.2.3.2 crashes when window title is too long. For example, you can create
HTML document with 91000 characters in its TITLE element and try to load that
with Mozilla browser. Firefox and Opera handle long titles, but I think this is
still bug of Xfce because panel, taskbar and all other applications crashes.

Reproducible: Always
Steps to Reproduce:
1. Create HTML document with 91000 characters in its TITLE element.
2. Try to load that page with Mozilla browser.
Actual Results:  
Xfce (panel, taskbar, applications) crashes.

Expected Results:  
Xfce should truncate window title when it's too long.

GTK1 version: 1.2.10-18
GTK2 version: 2.8.9-2
Comment 1 Olivier Fourdan editbugs 2005-12-26 18:15:56 CET
No crash here, even with 750000 characters as title.... Can you try with a
stable version of gtk+ please?

That seems odd because:

- All components are independent. One may crash but there is no reason for the
others to crash.
- In the WM, the window title is not bound, so there os no risk of memory
corruption.
Comment 2 Olivier Fourdan editbugs 2005-12-26 18:18:21 CET
Sorry gtk+ 2.8.9 is stable! So I don't know. Does the window manager crashes?
What version of Xorg?
Comment 3 Olivier Fourdan editbugs 2005-12-26 18:26:40 CET
Created attachment 374 
An HTML file with a 750.000+ title filed

Does that file crash for you?
Comment 4 Brian J. Tarricone (not reading bugmail) 2005-12-26 19:35:14 CET
Could the length be a coincidence?  I remember some really old bugs where
invalid UTF-8 could crash the WM, and it might crash other parts of Xfce that
show the window title.
Comment 5 Olivier Fourdan editbugs 2005-12-27 22:12:52 CET
Hard to say, as I can't tell what part of "Xfce" crash. BTW, the bug you refer
never caused a crashed of the WM, just the title to be displayed on 2 lines when
the UTF sequence was containing a cariage return. xfwm4 relies on pango for all
its font rendering routines. 

BTW, I can't reproduce the crash so I need some more information:

- Does the test file crash for the reporter?
- What exact part of Xfce crash?

Without that required informations, I can't investigate on that bug since I
can't reproduce it.

Thanks
Olivier.
Comment 6 Jari Jokinen 2005-12-28 01:57:56 CET
(In reply to comment #3)
> Does that file crash for you?

Yes it does. This also causes crash:

  xterm -title `perl -e 'print "a" x 25000'`

I ran xterm with some random length titles: 6960 character title is ok, 9800 and
19900 messes up titlebar text but not crash, 21000 crash.

Processes xfwm4, xftaskbar4 and xfce4-panel crash.

I'm using Xorg version 6.8.2.

Maybe that crashing has something to do with those reported bugs:

"Bug 315070 - metacity crashes when managing windows that have long titles"
http://bugzilla.gnome.org/show_bug.cgi?id=315070

"Bug 317362 - should not allow overlong window titles"
http://bugzilla.gnome.org/show_bug.cgi?id=317362
Comment 7 Olivier Fourdan editbugs 2005-12-28 15:17:39 CET
It is indeed a bug with cairo. I have a fix very similar to the one used in
metacity thnaks to the link you provide. Unfortunately https is not functional
on our svn, so it'll have to wait before I can commit the fix...
Comment 8 Olivier Fourdan editbugs 2005-12-29 20:30:38 CET
It's now fixed in svn, so I'm closing the bug. Thanks a lot for raising that
issue and finding a fix.
Comment 9 Olivier Fourdan editbugs 2005-12-29 20:35:35 CET
Eeek, I meant fixed!

Bug #1296

Reported by:
Jari Jokinen
Reported on: 2005-12-26
Last modified on: 2009-07-15

People

Assignee:
Olivier Fourdan
CC List:
0 users

Version

Attachments

An HTML file with a 750.000+ title filed (1.53 KB, text/plain)
2005-12-26 18:26 CET , Olivier Fourdan
no flags

Additional information