! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Disable single click to mute applicactions
Status:
RESOLVED: MOVED
Product:
Xfce4-notifyd
Component:
general

Comments

Description Matias De lellis 2016-11-10 16:35:14 CET
Created attachment 6898 
Disable single click to mute applicactions

Hi simmon,
I found that when clicking on the application list, it automatically changes the check to mute the notifications.. and it seems confusing.. :S

I attach a patch to disable singe click activations..

Regards.
Comment 1 Simon Steinbeiss editbugs 2016-11-11 20:23:36 CET
Hi,
this is actually a feature I implemented (the gtkswitch doesn't get activated by default) and helps when navigating through the list with a keyboard.
I don't think it's really confusing (the same happens when clicking the label of a gtkcheckbox or gtkradiobutton) and it also helps you with your mouse (otherwise you have to directly click the gtkswitch).

So for now I'd rather keep it as is.
Comment 2 Matias De lellis 2016-11-11 22:30:26 CET
Hi Simon,
I understand your intention, but should not be activated with simple click, and with the keyboard you can always activate the row (and therefore the switch) with the space key..

Also it allow you to select multiple rows of applications and silence them at the same time.. ;)

Regards,
Matias
Comment 3 Simon Steinbeiss editbugs 2016-11-13 23:26:08 CET
(In reply to Matias De lellis from comment #2)
> I understand your intention, but should not be activated with simple click,
> and with the keyboard you can always activate the row (and therefore the
> switch) with the space key..

Why should it not? Everything in Xfce works this way. Try to change a theme, select one from the list and boom, it's applied. Xfce doesn't have the "apply" button logic (small exception is the display dialog to avoid too much flickering or resolution change when you want to set up a presentation or something).

> Also it allow you to select multiple rows of applications and silence them
> at the same time.. ;)

Yeah, tbh that's really not a valid use-case for me. It still takes you at least one click more to multi-select many rows and the activate/deactivate them.

To be honest I see no reason why this behavior would be confusing at all. And the only use-case seems to be "multi-select", which is not a real use-case for me, cause when would you really want to programmatically multi-select anything here? You either mute or unmute an app, that's it. For that you click. Once. If you mis-click, you click again, nothing happened.
Comment 4 Matias De lellis 2016-11-14 14:14:11 CET
Hi Simon,

> Why should it not? Everything in Xfce works this way. Try to change a theme, select one from the list and boom, it's applied. Xfce doesn't have the "apply" button logic. 

Well.. On Xfce world see the system tray panel plugin, indicator panel plugin, xfce4-mixer control selection, parole plugin selection.. I think those are more valid examples.. List with activatable checkboxs.. ;)

In gnome3 apps: Power manager settings, Accessibility settings or the notification manager himself...

I just thought of these examples with respect to the bug.. Maybe I should have commented it before.. haha..

> Yeah, tbh that's really not a valid use-case for me. It still takes you at least one click more to multi-select many rows and the activate/deactivate them.

Nor is it interesting for me, but I commented that it could be done .. ;)

> To be honest I see no reason why this behavior would be confusing at all.

Honestly just not expect that behavior, but seeing other applications IMHO you have more reason to change it... :S

p.s: In the appearance panel, seems right that change automatically because you should see the appareance change, but I would like to add an undo button to return to the initial state of when the panel was opened .. I will soon propose a patch ..; =

Regards
Matias.
Comment 5 Drew Henry 2017-11-05 05:19:49 CET
I actually have also found this to be a little bit confusing, primarily because clicking on a row both toggles the application on or off and also highlights the row. With the exceptions of selections (e.g. themes where you click to select a theme), typically clicking on a row toggles a checkbox or highlights the row but does not do both. So because highlighting usually doesn't toggle anything, I've found myself out of habit wanting to click on whatever row I am thinking of toggling before actually toggling it in order to highlight it and then am a little thrown off when I see the switch change from on to off. It's not a big deal, but I see where Matias is coming from. I've also clicked on some applications with no intention of toggling them while experimenting to see if there was a way to delete applications from the list (e.g. applications that are no longer installed).

Examples:
-With files you click to highlight before copying/deleting/editing.
-In "Session and Startup -> Session" and "Session and Startup -> Application Autostart", clicking highlights without toggling anything.
-In all checkbox settings, clicking anywhere in the row will toggle the checkbox but it will not highlight the row.*

*Actually, in defense of the current setup, I was able to find one exception to this in "Desktop -> Icons -> Default Icons"
Comment 6 Git Bot editbugs 2020-05-24 20:04:51 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/apps/xfce4-notifyd/-/issues/5.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #12953

Reported by:
Matias De lellis
Reported on: 2016-11-10
Last modified on: 2020-05-24

People

Assignee:
Simon Steinbeiss
CC List:
1 user

Version

Attachments

Disable single click to mute applicactions (1.03 KB, patch)
2016-11-10 16:35 CET , Matias De lellis
no flags

Additional information