Created attachment 6897 Fix support to gtk 3.14 Hi Simmon, Congratulations for all the work .. ) I am maintaining an backport of xfce4 4.12 in a debian stable based distro.. with Gtk 3.14. :S I attach a patch to correct code that depends 3.16.. ;)
Created attachment 6899 Fix support to gtk 3.14 Replace old diff wit git patch..
Wowza, I'm surprised it works with Gtk3.14. If it's all ok until now I can try to keep it that way at least until I bump to version 0.4.0 (at some point I'd like to get rid of ifdefs and double theme maintenance). Anyway, if this is all that is needed in order to support Gtk+3.14 I'm ok with it. Just to be sure: I won't test notifyd against Gtk+3.14 so this will be just implicit support and I can't promise I'll break it (not consciously though) in future commits/releases. I'd really like to keep the testing to one or two Gtk+ releases. Pushed to master: https://git.xfce.org/apps/xfce4-notifyd/commit/?id=7beb4759ca546decc3280c225acdda69cd48e199
Created attachment 6998 Update path.. to last upstream release..
Wait is this a patch or a diff? Also, sorry for breaking Gtk3.14 again, but it's just not on my radar at all.
Created attachment 6999 0001-Fix-compilation-on-Gtk3.14.patch > Wait is this a patch or a diff? Do again with git diff.. > Also, sorry for breaking Gtk3.14 again, but it's just not on my radar at all. Do not worry.. It's a shame to not pack it in debian jessie for too few changes.. But when you have to advance in bigger versions it will be understandable.. ;) Regards,
Fixed in master (again): https://git.xfce.org/apps/xfce4-notifyd/commit/?id=e9a7e3dbbbf5f18ca94b20272a3f0d5827dc7877