! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
GTK3 Panel Plugins with Meters Do Not Use Proper Background Colors
Status:
RESOLVED: INVALID
Severity:
enhancement
Product:
Xfce4-panel
Component:
General

Comments

Description saunders.52 2016-11-03 04:12:19 CET
Created attachment 6887 
Visual of the issue. On the left is xfce4-cpugraph-plugin using GTK2, on the right is xfce4-netload-plugin with the issue.

Recent versions of GTK3-based panel plugins with meters (xfce4-battery-plugin 1.1.0, xfce4-wavelan-plugin 0.6.0, xfce4-netload-plugin 1.3.0) have had blank white backgrounds for the meters as opposed to using the background of the rest of the panel in a dark theme (or if the panel is set to a dark color manually). It looks distinctly out of place and is rather distracting.

Attached is an image showing xfce4-cpugraph-plugin on the left using GTK2 and matching the background color of the panel, and the netload plugin on the right with the white backgrounds. It's done with the numix-frost theme, but I've verified it is not related to that theme by setting the panel to pure black in the panel config to similar results.

Apologies if this is the wrong item to file the bug under, but this seems to be the root library used by all the plugins to get gtk2/gtk3.
Comment 1 Landry Breuil editbugs 2016-11-29 09:03:31 CET
Cant it be a theme issue ? Simon, any idea ?
Comment 2 saunders.52 2016-11-29 09:05:50 CET
If I change themes, it does go to a different color for the background of the bar in some cases (see the Adwaita theme for that), but it isn't matching in a lot of cases and doesn't follow at all if I set the toolbar to a fixed color.
Comment 3 Simon Steinbeiss editbugs 2018-06-08 10:15:34 CEST
This is a theme issue. I've recently fixed it in Greybird: https://github.com/shimmerproject/Greybird/commit/10929b1211b7a3377e1d8bcb2b2b37317b709d82

In theory we could include some code in the panel, but that would also break some themes...
Comment 4 Simon Steinbeiss editbugs 2018-11-17 01:15:45 CET
This has to be fixed by themes. The issue you reported concretely was fixed in the Greybird theme, as mentioned above.

Bug #12934

Reported by:
saunders.52
Reported on: 2016-11-03
Last modified on: 2018-11-17

People

Assignee:
Nick Schermer
CC List:
5 users

Version

Version:
4.13.2

Attachments

Additional information