! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
tab activity color not working in Gnome3 environment
Status:
RESOLVED: FIXED
Product:
Xfce4-terminal
Component:
General

Comments

Description Ian 2016-09-15 11:16:20 CEST
Recent updates to either xfce4-terminal and/or Gnome have caused tab activity color to stop working i.e. the tab title no longer changes color when activity occurs.

I'm using Fedora 24, Gnome3 desktop.
Comment 1 Igor editbugs 2016-09-15 11:59:13 CEST
Works for me with this commit: https://git.xfce.org/apps/xfce4-terminal/commit/?id=971c86c5664d3db498552987595839c3fc89fca0
It's not in 0.6.92; can you apply the patch and try it?
Comment 2 Ian 2016-09-15 12:25:22 CEST
(In reply to Igor from comment #1)
> Works for me with this commit:
> https://git.xfce.org/apps/xfce4-terminal/commit/
> ?id=971c86c5664d3db498552987595839c3fc89fca0
> It's not in 0.6.92; can you apply the patch and try it?

Unfortunately that's made no difference for me. I've attached a screenshot showing 2 tabs - the hidden tab has a while loop outputting to console...
Comment 3 Ian 2016-09-15 12:25:54 CEST
Created attachment 6840 
screenshot of terminal
Comment 4 Igor editbugs 2016-09-15 12:36:51 CEST
The following scenario works in Fedora 25 Gnome session for me:
running `for i in $( ls ); do echo $i && sleep 1; done` in an inactive tab makes its label red.

When running a patched terminal, don't you have other instances of xfce4-terminal running? If yes, you either need to first close them, or to run the binary you've built in the following manner: `./termina/xfce4-terminal --disable-server`.
Comment 5 Egmont Koblinger 2016-09-15 20:49:51 CEST
Doesn't work for me either (Ubuntu Xenial, Unity). [Works with the gtk2 version.]
Comment 6 Egmont Koblinger 2016-09-15 20:52:06 CEST
(For the record, I have VTE from git (current master HEAD, will be released as 0.46.0 next week), the rest is stock Ubuntu.)
Comment 7 Igor editbugs 2016-09-15 21:24:41 CEST
(In reply to Egmont Koblinger from comment #5)
> Doesn't work for me either (Ubuntu Xenial, Unity). [Works with the gtk2
> version.]

That is veeery weird.
I haven't tried it under Unity (will try to check to tomorrow) but the indication works for me under Cinnamon, Xfce, and Gnome.

Please verify your settings: inactivity timeout should be > 0, and active tab color should differ from the default tab label color.
Comment 8 Egmont Koblinger 2016-09-15 21:30:41 CEST
Prefs -> Appearance -> Reset tab activity incicator after 2 seconds
Prefs -> Colors -> Tab activity color is dark red
Comment 9 Igor editbugs 2016-09-15 21:45:18 CEST
(In reply to Egmont Koblinger from comment #8)
> Prefs -> Appearance -> Reset tab activity incicator after 2 seconds
> Prefs -> Colors -> Tab activity color is dark red

Right, these are default values.

Can you do me a favor and perform some debugging?
Please insert the following string in the beginning of terminal_screen_vte_window_contents_changed() function (before "if (screen->tab_label == NULL"):
  printf("screen=%p state=%x\n", screen, gtk_widget_get_state_flags (screen->terminal));
and post the output here. Thanks!
Comment 10 Egmont Koblinger 2016-09-15 22:06:01 CEST
I'm sorry, I had a build from about a week ago. With the latest git correctly becomes red (apart from its background being transparent, as mentioned in bug 12845).
Comment 11 Igor editbugs 2016-09-15 22:10:57 CEST
(In reply to Egmont Koblinger from comment #10)
> I'm sorry, I had a build from about a week ago. With the latest git
> correctly becomes red (apart from its background being transparent, as
> mentioned in bug 12845).

Ok, thanks.
Does not this change fix menubar transparency for you? https://git.xfce.org/apps/xfce4-terminal/commit/?id=e1d6fd3d497508e293240ce2d9835db42aa7cc5f
Comment 12 Egmont Koblinger 2016-09-15 22:14:17 CEST
Not in Ambiance/Radiance. In Adwaita it's okay. I guess we should continue this discussion at the other bug :)
Comment 13 Igor editbugs 2016-09-15 22:17:43 CEST
Okay, I'm closing this one as fixed.

Bug #12849

Reported by:
Ian
Reported on: 2016-09-15
Last modified on: 2016-09-15

People

CC List:
2 users

Version

Version:
0.6.92

Attachments

screenshot of terminal (43.92 KB, image/png)
2016-09-15 12:25 CEST , Ian
no flags

Additional information