! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Make frame double-click maximizing optional


Description Chris Angelico 2016-09-14 19:47:19 CEST
Accidentally double-clicking on the frame of a window maximizes it in one dimension only, which cannot be undone (have to manually resize the window back to its original size). Please can this be made configurable? I would very much like to simply disable the whole feature.
Comment 1 ToZ editbugs 2016-09-14 19:58:04 CEST
Created attachment 6839 
clientfill_on_border_doubleclick patch

The attached patch creates a (hidden) "clientfill_on_border_doubleclick" xfconf property that can be set to FALSE (default is TRUE to retain current functionality) that can be applied against the current git tree.
Comment 2 ToZ editbugs 2016-09-14 20:05:09 CEST
Associated forum thread: https://forum.xfce.org/viewtopic.php?pid=43022
Comment 3 Olivier Fourdan editbugs 2017-06-27 16:44:17 CEST
I am really not in favour of adding an option for anything and everything...
Comment 4 Lasse Hillerøe Petersen 2017-06-27 18:47:07 CEST
Just today, I found myself puzzled and tremendously annoyed by this bug again several times, and eventually googled my way here. If the bug isn't fixed (because some may consider it a feature?) then at least ensure that the action is reversible by another doubleclick in the border or by clicking the maximize button, like other forms of maximizing. (And if the border could be made wider than 1 pix and easier to hit in the process, it would be great, although that's probably a different bug.)
Comment 5 Olivier Fourdan editbugs 2017-06-27 19:09:26 CEST
Of course it's a feature, things usually don't get implemented "by chance" ...

What you get is called "filling", it's not a state (unlike maximizing) and therefore is not meant to be undone.

The 1 pix border is your theme, another issue discussed at length elsewhere and I won't repeat myself here.
Comment 6 Chris Darroch 2017-09-21 08:24:09 CEST
First of all, I wanted to say thank you for Xfce!  As a longtime KDE user who finally made the switch, I'm thrilled with the elegance, stability, and simplicity that Xfce brings, while still providing every feature I could want.  Thank you!

The only thing I've stumbled over is the exact same issue I believe is described in the original post in the related forum thread (https://forum.xfce.org/viewtopic.php?pid=43022) to this enhancement request.

More specifically, in Settings > Window Manager > Advanced, I have selected "Shade window" for the "Double click action".  Then, occasionally, when I was trying to un-shade a window by double-clicking, because the title bar is a narrow target, I would happen to double-click on the border.  This would "fill" the window in the vertical dimension -- but the window would still be shaded, so I'd just see the title bar jump to the top of the screen.  This was very puzzling and quite frustrating -- especially since, once I correctly un-shaded the window, I'd find it maximized in the vertical dimension.

Or, even more difficult to understand, if I happened to double-click on the border (causing the shaded window to "invisibly" expand vertically, and the title bar to jump to the top of the screen, as described), and then did it *again* (this time causing no visible change), and then finally successfully un-shaded the window on a third try, I'd find it shrunken in the vertical dimension -- usually so that the lower border just aligned with, or slightly overlapped, the nearest other window.  This specific behaviour might be a bug, I'm not sure; it doesn't happen when the window is un-shaded and you double-click on the border twice.  (I'm using 4.12.0.)

Eventually I found this enhancement request and the associated forum thread by searching around on Google, and learned how I was accidentally triggering the "fill" behaviour.

At any rate, I can well understand the desire not to make every feature optional, and in this case, to not make "filling" optional.

However, to prevent confusion when a window is shaded, might I offer a possible compromise, which would be to always disable the filling action when a window is shaded?  This makes sense to me, since the title bar is usually quite narrow, so mistakes are easier to make, plus, it would prevent the shaded title bar "jumping" to the top of the screen.

Or, if even that's too extreme a change, a more restrictive compromise might be to disable the filling action when both (a) a window is shaded and (b) the Settings > Window Manager > Advanced > Double click action is set to "Shade window".  That would help those of us who expect to double-click on the title bar to un-shade the window and happen to miss the target slightly and hit the border instead!

Thanks again for Xfce; it makes my Linux desktop a pleasure to use.
Comment 7 Git Bot editbugs 2020-05-29 12:12:31 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfwm4/-/issues/230.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #12848

Reported by:
Chris Angelico
Reported on: 2016-09-14
Last modified on: 2020-05-29


Olivier Fourdan
CC List:
3 users




Additional information