! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[Xfce4-notifyd] no theming for callback button
Status:
RESOLVED: FIXED
Priority:
Low
Severity:
minor
Product:
Xfce4-notifyd
Component:
general

Comments

Description Christian Hesse 2016-09-12 16:35:03 CEST 
Created attachment 6831 
Notification by claws-mail without theming for callback button

Sometimes the callback button is not themed (or rather themed by the default desktop theme). Looks like new-mail notification in claws-mail triggers this, though it does not happen all the time.
Comment 1 Christian Hesse 2016-09-12 16:36:11 CEST 
Created attachment 6832 
for reference: sample notification with dark callback button

I think it should look like this...
Comment 2 Simon Steinbeiss editbugs 2016-09-12 18:03:33 CEST 
I just checked myself and I can reproduce the problem. I'll look into fixing it.
Comment 3 Simon Steinbeiss editbugs 2016-09-12 18:18:41 CEST 
Created attachment 6833 
Fix callback button theming

Ok, I think I've found a solution. Could you check whether the patch fixes the issue for you? (It does for me.)
Comment 4 Christian Hesse 2016-09-12 20:45:11 CEST 
Compiled and installed.
Give me a day or two for testing.

Thanks a lot!
Comment 5 Simon Steinbeiss editbugs 2016-09-12 22:35:48 CEST 
Sure, lemme know.
Comment 6 Christian Hesse 2016-09-14 09:28:13 CEST 
Looks good, I did not notice an un-themed button. Thanks a lot!
Comment 7 Simon Steinbeiss editbugs 2016-09-14 09:47:11 CEST 
Nice, thanks for testing! Pushed to master:
https://git.xfce.org/apps/xfce4-notifyd/commit/?id=47d331198b6d16c076313a2808470d7b904fd6ed
Comment 8 Simon Steinbeiss editbugs 2016-09-14 09:52:14 CEST 
Marking as fixed.

Bug #12841

Reported by:
Christian Hesse
Reported on: 2016-09-12
Last modified on: 2016-09-14

People

Assignee:
Simon Steinbeiss
CC List:
0 users

Version

Version:
0.3.2
Target Milestone:
---

Attachments

Notification by claws-mail without theming for callback button (9.42 KB, image/png)
2016-09-12 16:35 CEST , Christian Hesse 		no flags
for reference: sample notification with dark callback button (8.01 KB, image/png)
2016-09-12 16:36 CEST , Christian Hesse 		no flags
Fix callback button theming (5.77 KB, patch)
2016-09-12 18:18 CEST , Simon Steinbeiss 		no flags

Additional information