! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Text not displays on the notification button
Status:
RESOLVED: FIXED
Severity:
trivial
Product:
Xfce4-notifyd
Component:
general

Comments

Description w3lifer 2016-09-10 23:47:56 CEST
Created attachment 6829 
screenshot

See attachement ...
OS: Xubuntu 16.04.1 LTS.
GTK: the result of `dpkg -l libgtk2.0-0 libgtk-3-0`:
  ii  libgtk-3-0:amd64   3.18.9-1ubuntu3.1  amd64
  ii  libgtk2.0-0:amd64  2.24.30-1ubuntu1   amd64
Comment 1 Simon Steinbeiss editbugs 2016-09-11 09:44:55 CEST
Hi, could you please post some instructions as to how to reproduce that? Thanks!
Comment 2 w3lifer 2016-09-11 11:02:00 CEST
(In reply to Simon Steinbeiss from comment #1)
> Hi, could you please post some instructions as to how to reproduce that?
> Thanks!

Oh, I spend some time to understand how I get the notification :)
How I understood, the notification displays when I install some software via *Software 3.20.1* program and self Software program is closed ...

So, I have done the steps to reproduce the notification:

1) > sudo apt purge gparted

2) go to the Software programm

3) type "gparted" in the search field

4) click "Install" button and *close* Software program

5) when GParted will be installed the notification is shown

I suppose this is not only true for GParted.
Comment 3 w3lifer 2016-09-11 11:03:20 CEST
Created attachment 6830 
screenshot 2
Comment 4 Simon Steinbeiss editbugs 2016-09-11 15:00:22 CEST
Alright, I can confirm the bug now. I'm wondering whether this is something that gnome-software is messing up or whether it's notifyd. I'll investigate.
Comment 5 Simon Steinbeiss editbugs 2016-09-17 05:28:35 CEST
Very strange, but it indeed seems like Gnome Software sends a notification with two actions, one is "default" (and has no label) and the other one is for launching the application.

I guess a valid workaround would be to not display buttons without labels as that can be presumed to be buggy and because the user can never know what they would do.
Comment 6 Simon Steinbeiss editbugs 2016-09-17 05:34:14 CEST
FWIW this should already be happening as there is a check whether the label or action-id are empty, for some reason it's not working in this case.
https://git.xfce.org/apps/xfce4-notifyd/tree/xfce4-notifyd/xfce-notify-window.c#n928
Comment 7 Simon Steinbeiss editbugs 2016-09-17 05:50:21 CEST
This has been fixed in git master and will be part of the next stable release (0.3.3).
https://git.xfce.org/apps/xfce4-notifyd/commit/?id=b59320b7c37ce44399b6d2fcc0672805b27e9a24
Comment 8 Simon Steinbeiss editbugs 2016-09-17 05:51:09 CEST
This is a potential candidate for backporting or including as a patch for the 0.2 series.

Bug #12834

Reported by:
w3lifer
Reported on: 2016-09-10
Last modified on: 2016-09-17

People

Assignee:
Simon Steinbeiss
CC List:
1 user

Version

Attachments

screenshot (15.38 KB, image/png)
2016-09-10 23:47 CEST , w3lifer
no flags
screenshot 2 (4.89 KB, image/png)
2016-09-11 11:03 CEST , w3lifer
no flags

Additional information