! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
widget is ignoring theme and displaying too much
Status:
RESOLVED: FIXED
Product:
Xfce4-power-manager
Component:
General

Comments

Description dmnc 2016-09-01 12:51:28 CEST
Created attachment 6816 
screenshot

xfce4-power-manager widget is ignoring theme settings after update ... it is very ugly when one uses dark theme. And there is no option to limit displayed informations, in previous version I had just icon and all details has been shown as tooltip.
Comment 1 ToZ editbugs 2016-09-01 15:52:09 CEST
To prevent the time and percentage from displaying:

xfconf-query -c xfce4-power-manager -p /xfce4-power-manager/show-panel-label --create -t int -s 0

This is a hidden option but it appears to default to 3 (show time and percentage) if not specified. This should probably be changed so the default is 0.

-----

As for the colour of the background, that looks like a GTK3 theming issue.
Comment 2 ToZ editbugs 2016-09-01 16:29:39 CEST
Created attachment 6818 
Set show-panel-label default to 0

Since show-panel-label is a hidden option, perhaps it's default should be 0 (zero) to maintain similar appearance when upgrading. Attached is a patch that sets the default value to 0.
Comment 3 haarp 2016-09-05 22:02:46 CEST
(In reply to ToZ from comment #2)
> Created attachment 6818 
> Set show-panel-label default to 0
> 
> Since show-panel-label is a hidden option, perhaps it's default should be 0
> (zero) to maintain similar appearance when upgrading. Attached is a patch
> that sets the default value to 0.

I would actually suggest that this be exposed as an option. After upgrading xfce4-power-manager recently, I was really upset when I couldn't find a way to disable it (until searching through the commit log and finding the hidden option)
Comment 4 dmnc 2016-09-20 11:36:52 CEST
(In reply to ToZ from comment #1)
> To prevent the time and percentage from displaying:
> 
> xfconf-query -c xfce4-power-manager -p /xfce4-power-manager/show-panel-label
> --create -t int -s 0
> 
> This is a hidden option but it appears to default to 3 (show time and
> percentage) if not specified. This should probably be changed so the default
> is 0.
> 
> -----
> 
> As for the colour of the background, that looks like a GTK3 theming issue.

Thank you for the solution, anyway I agree with haarp, there should be an option for this (and I think this is that step to resolve this issue).

As for the colour, yes, probably GTK3 is leaking more and more into my system. If I understand well, there will be more and more GTK3 xfce plugins and apps at all (today I found xfce4-clipman-plugin based on GTK3) and there is no way how to stay on GTK2 and be up-to-date. Correct me please if I'm wrong. So I'm going to find a way how to make GTK3 apps look like GTK2 and deal with it...
Comment 5 Simon Steinbeiss editbugs 2017-10-31 00:32:46 CET
I have added a properties dialog to the panel plugin that exposes this setting.
https://git.xfce.org/xfce/xfce4-power-manager/commit/?id=e319a4932617fed22d8ddb27fe4a917f973f2e58
Comment 6 dmnc 2017-10-31 09:37:30 CET
Great news, thank you for your work!

Bug #12811

Reported by:
dmnc
Reported on: 2016-09-01
Last modified on: 2017-10-31

People

Assignee:
Ali Abdallah
CC List:
7 users

Version

Attachments

screenshot (5.94 KB, image/png)
2016-09-01 12:51 CEST , dmnc
no flags
Set show-panel-label default to 0 (843 bytes, patch)
2016-09-01 16:29 CEST , ToZ
no flags

Additional information