With 0.6.91 here it seems to ignore my width x height geometry. Doing a: xfce4-terminal --geometry=100x50 I see the terminal appear with what looks like the correct size, then it immedately resizes to 80x23. I have in prefs default geometry set to 100x50. Also, on login to my session, all my saved terminals resize to 80x23 as well. If I give it something gigantic like 500x500 it comes up fullscreen.
Please describe your system. I'm not seeing anything like that on Arch with Cinnamon, Fedora 24 with Gnome, Debian 8 with Xfce, all running X. The geometry is set very precisely. I do see something similar on Fedora 24 with wayland - the initial geometry is incorrect, as well as the terminal window keeps increasing on opening and closing tabs. It seems that window resize gtk functions are functioning differently under wayland.
Odd. My setup is Fedora rawhide with Xfce/X11 in this case. I'll try some things to isolate this more soon (newly created user to rule out a weird setting and downgrading back to 0.6.90 to confirm it works there).
I still see this on a newly created user. I definitely see this go away when I downgrade to 0.6.90. ;( I can't think of anything else odd in my setup off hand. I guess I will ask the folks in the recent Fedora bugs to try my scratch build and see if they see it.
Reverted commit https://git.xfce.org/apps/xfce4-terminal/commit/?id=39f966d tentatively resolves the "geometry" issue with GTK+ 3.21.5, on Rawhide / Fedora 26, it also produces a known regression - "inconstant" rows number, already well described in several bug reports, and resolved in a few commits. --- terminal/terminal-app.c | 4 ++++ terminal/terminal-screen.c | 3 +++ 2 files changed, 7 insertions(+) diff --git a/terminal/terminal-app.c b/terminal/terminal-app.c index 85b8af3..42fc860 100644 --- a/terminal/terminal-app.c +++ b/terminal/terminal-app.c @@ -813,8 +813,12 @@ terminal_app_open_window (TerminalApp *app, { active_terminal = terminal_window_get_active (TERMINAL_WINDOW (window)); if (G_LIKELY (active_terminal != NULL)) +#if GTK_CHECK_VERSION (3,21,5) + terminal_screen_set_size (active_terminal, width, height); +#else terminal_screen_force_resize_window (active_terminal, GTK_WINDOW (window), width, height); +#endif } if ((mask & XValue) && (mask & YValue)) { diff --git a/terminal/terminal-screen.c b/terminal/terminal-screen.c index 23f4d92..8e7f56b 100644 --- a/terminal/terminal-screen.c +++ b/terminal/terminal-screen.c @@ -1820,6 +1820,9 @@ terminal_screen_force_resize_window (TerminalScreen *screen, glong char_width; glong char_height; +#if GTK_CHECK_VERSION (3,21,5) + return; +#endif terminal_return_if_fail (TERMINAL_IS_SCREEN (screen)); terminal_return_if_fail (VTE_IS_TERMINAL (screen->terminal)); -- 2.9.3
Yep. That does indeed fix things here.
Gtk is killing me... Looks like I have to update Fedora in my VM in order to 3.21.5 and try to deal with it. Thanks for the info, guys.
Kevin, poma, Could you please check if the following patch fixes it for you? https://github.com/f2404/xfce4-terminal3/commit/e96ebb7927fd93b19ca744c011abbafe2fad62f1
It does indeed appear to here.
GTK+ 3.21.5 & GTK+ 3.20.9 All right!
Fixed by https://git.xfce.org/apps/xfce4-terminal/commit/?id=3af6615150b1b7fbc97a28b887cfb6a847ffb46c Thanks guys!
I have just released 0.6.92 containing the fix.
Thanks much.
doc: refers to the proper gtk_minor_version 3.21.5 xfbz#12810 --- NEWS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS b/NEWS index c4b86f2..bb2c28c 100644 --- a/NEWS +++ b/NEWS @@ -1,7 +1,7 @@ 0.6.92 ====== - Fix geometry setting (default ot provided via the command line option) - for GTK 3.20.5 (bug #12810) + for GTK 3.21.5 (bug #12810) - Remove "Update utmp/wtmp records when command is launched" setting since the feature has been removed from vte (bug #12817) - Replace deprecated GtkTable with GtkGrid in Preferences --
doc: typo fix --- NEWS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS b/NEWS index bb2c28c..63ea301 100644 --- a/NEWS +++ b/NEWS @@ -1,6 +1,6 @@ 0.6.92 ====== -- Fix geometry setting (default ot provided via the command line option) +- Fix geometry setting (default or provided via the command line option) for GTK 3.21.5 (bug #12810) - Remove "Update utmp/wtmp records when command is launched" setting since the feature has been removed from vte (bug #12817) --
Time for beauty sleep ;)
Thanks poma!