! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Lost cursor focus
Status:
RESOLVED: FIXED
Product:
Xfce4-terminal
Component:
General

Comments

Description Olivier Duchateau 2016-08-31 20:27:42 CEST
Since upgrade to 0.6.91, I lost cursor focus, when I launch xfce4-terminal. Previous one was fine.

I saw, you removed the 'gtk_widget_grab_focus' method in 'terminal_screen_force_resize_window' function, I re-added it, but cursor is still unfocusing.

I use these current libraries:
* Gtk+ 3.18.8
* Vte 0.42.4
Comment 1 Igor editbugs 2016-08-31 21:14:09 CEST
Hi,

Are other apps (e.g. gnome-terminal) getting focus when they are launched?

I can disable new windows getting focus (in the openbox settings), and then no new window will get it. But once I've enabled the setting, new terminal windows get the focus just fine.
Comment 2 Olivier Duchateau 2016-09-06 21:57:37 CEST
(In reply to Igor from comment #1)
> Hi,
> 
> Are other apps (e.g. gnome-terminal) getting focus when they are launched?
> 
> I can disable new windows getting focus (in the openbox settings), and then
> no new window will get it. But once I've enabled the setting, new terminal
> windows get the focus just fine.

Problem still persists with 0.6.92.

When I open new terminal, focus is not anymore available even if I click in window (or launch basic command, e.g. ls, cd and so on).

I tried tilda (build against Vte 0.42.4) and cursor is fine like the 0.6.90 (and previous releases).
Comment 3 Igor editbugs 2016-09-07 11:01:28 CEST
Thanks for the update.

However, I've installed FreeBSD 10.3 in a VM, installed Xfce there and built the terminal from git. And the window focus is working fine for me.
What DE/WM are you using?
Comment 4 Igor editbugs 2016-09-07 17:11:47 CEST
Together with the IRC user Harzilein, we have found the reason of the issue today - it's the compiler. When compiled with gcc (in opposite to clang), there's no cursor focus issue.

Harzilein has also provided a Makefile: http://sprunge.us/IhIA
Comment 5 Igor editbugs 2016-09-07 17:57:32 CEST
Actually, I have fixed a bug in the code - should work with clang now.
https://git.xfce.org/apps/xfce4-terminal/commit/?id=7e657dcf660b1b6ea2fc94cffb1f08f4d01063b5
Comment 6 Olivier Duchateau 2016-09-07 18:10:34 CEST
I use Xfwm4.

Lost focus appears with the GCC compiler (default in 9.3-RELEASE). I'm maintainer of the Xfce stack under FreeBSD, so I test each release under 9.3-RELEASE and 10.3 / 11.0-RC2.

Harzilein's Makefile is wrong, when we need to use GCC instead compiler found in base system.

I'm trying to test your patch.
Comment 7 Igor editbugs 2016-09-07 18:32:00 CEST
Ok, please keep me updated.
Comment 8 Olivier Duchateau 2016-09-07 22:17:29 CEST
(In reply to Igor from comment #7)
> Ok, please keep me updated.

Patch works fine, thanks!
Comment 9 Igor editbugs 2016-09-08 08:49:54 CEST
(In reply to duchateau.olivier from comment #8)
> (In reply to Igor from comment #7)
> > Ok, please keep me updated.
> 
> Patch works fine, thanks!

Great! Thanks for reporting.

Bug #12807

Reported by:
Olivier Duchateau
Reported on: 2016-08-31
Last modified on: 2016-09-08

People

CC List:
1 user

Version

Version:
0.6.92

Attachments

Additional information