! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Tabs in the new terminal version for Fedora x86_64 are too big
Status:
RESOLVED: FIXED
Product:
Xfce4-terminal
Component:
General

Comments

Description Philip Rhoades 2016-08-29 06:16:38 CEST
In the Alpha version of Fedora x86_64 the tabs are about 3 times too high, too wide and the font on the tab is too big - see here for more info:

https://bugzilla.redhat.com/show_bug.cgi?id=1369002

Phil.
Comment 1 poma 2016-08-29 09:53:44 CEST
Created attachment 6799 
VTEs TABs G-design

This is actually an issue with the theming in GTK+ 3, i.e. with Adwaita and Adwaita based themes.
Try with an older GTK+ 3 theme, and notice the difference;
e.g.
dnf install albatross-gtk\*


https://bugzilla.gnome.org
is your friend
Comment 2 Igor editbugs 2016-08-29 11:32:26 CEST
Hi Phil,
In fact, this is the gtk3 widget GtkNotebook which draws the tabs of such enormous size. I have found to way to change their size from the code.
But, as poma has already mentioned, gtk3 theming should be able to help.
Comment 3 Panu Matilainen 2016-08-29 12:29:01 CEST
Well, changing to eg. albatross theme helps for the tab, but at least here it messes up the menu in turn, the menus are all now all packed together so closely some letters overlap etc. Which is might be another more or less related bug, dunno.
Comment 4 Igor editbugs 2016-08-29 12:33:00 CEST
(In reply to Igor from comment #2)
> Hi Phil,
> In fact, this is the gtk3 widget GtkNotebook which draws the tabs of such
> enormous size. I have found to way to change their size from the code.

s/I have found to way/I have found no way/
Comment 5 poma 2016-08-29 17:48:36 CEST
(In reply to Panu Matilainen from comment #3)
> Well, changing to eg. albatross theme helps for the tab, but at least here
> it messes up the menu in turn, the menus are all now all packed together so
> closely some letters overlap etc. Which is might be another more or less
> related bug, dunno.


Man, you are taking it literally. :)
Albatross theme is just a showcase for this particular issue,
otherwise it is de facto unmaintained.

Even if someone intends to upgrade
https://github.com/shimmerproject/Albatross/issues/10
it would most likely be based on the Adwaita theme,
which brings us back to the original problem.

Even if Igor make it happen for the Xfce Terminal,
the issue still stands up for the other GTK+ 3 based terminals.
Comment 6 Panu Matilainen 2016-08-30 12:47:26 CEST
(In reply to poma from comment #5)
> Man, you are taking it literally. :)
> Albatross theme is just a showcase for this particular issue,
> otherwise it is de facto unmaintained.

Well it was a literal example :) FWIW the same happened with clearlooks-phenix-gtk* themes too so maybe there's a more generic issue there.
Comment 7 poma 2016-08-31 00:29:52 CEST
(In reply to Panu Matilainen from comment #6)
> (In reply to poma from comment #5)
> > Man, you are taking it literally. :)
> > Albatross theme is just a showcase for this particular issue,
> > otherwise it is de facto unmaintained.
> 
> Well it was a literal example :) FWIW the same happened with
> clearlooks-phenix-gtk* themes too so maybe there's a more generic issue
> there.


The wise man,
here you can find themes to test
http://goo.gl/Gm4ffO
themes-gtk+/
Comment 8 Igor editbugs 2016-09-10 21:37:19 CEST
Here is the detailed explanation on CSS customization for GTK 3.20: https://www.reddit.com/r/gnome/comments/4e9s4d/size_of_tabs_in_gnometerminal/
Comment 9 Igor editbugs 2016-10-21 08:37:12 CEST
*** Bug 12911 has been marked as a duplicate of this bug. ***
Comment 10 Kevin Fenzi 2016-12-15 22:10:29 CET
There's several fedora users hitting this and finding it a pretty big usablity issue. (see downstream bug https://bugzilla.redhat.com/show_bug.cgi?id=1369002 )

Is there any chance of revisiting this and seeing if there's any possible solution? Or perhaps we should see if gtk3 folks will adjust GtkNotebook to better handle this?
Comment 11 Igor editbugs 2016-12-16 12:15:54 CET
(In reply to Kevin Fenzi from comment #10)
> There's several fedora users hitting this and finding it a pretty big
> usablity issue. (see downstream bug
> https://bugzilla.redhat.com/show_bug.cgi?id=1369002 )
> 
> Is there any chance of revisiting this and seeing if there's any possible
> solution? Or perhaps we should see if gtk3 folks will adjust GtkNotebook to
> better handle this?

Hi Kevin,

The recipe from https://bugzilla.xfce.org/show_bug.cgi?id=12796#c8 is working fine for me on Arch; it's also working fine on Fedora running in a VM. I don't understand why your users could be experiencing issues with it.

Below is my gtk.css, just for reference:

/* https://www.reddit.com/r/gnome/comments/4e9s4d/size_of_tabs_in_gnometerminal/ */

notebook tab {
  min-height: 0;
  padding-top: 2px;
  padding-bottom: 2px;
}

notebook tab button {
  min-height: 0;
  min-width: 0;
  padding: 2px;
  margin-top: 2px;
  margin-bottom: 2px;
}

notebook button {
  min-height: 0;
  min-width: 0;
  padding: 2px;
}
Comment 12 poma 2016-12-16 20:17:05 CET
Created attachment 6928 
xfce4-terminal grey-themes tabs

Test themes can be found here:
http://goo.gl/Gm4ffO
source/etc/

lightgrey-theme-3.22.5-2.fc24.src.rpm
darkgrey-theme-3.22.5-2.fc24.src.rpm
duskgrey-theme-3.22.5-2.fc24.src.rpm


If needed, the archives can be extracted from source rpm package:
$ for theme in *src.rpm ; do rpm2cpio $theme | cpio -i ; done
Comment 13 poma 2016-12-16 20:50:44 CET
BTW Greybird 3.22.0 delivers bug fixes,
https://github.com/shimmerproject/Greybird/releases/tag/v3.22.0

and some of them are "Deflate the notebook tabs"
- Make Gtk3 notebook tabs the size of Gtk2
  https://github.com/shimmerproject/Greybird/commit/26d8241.patch
- Decrease tab height in the terminal, gedit etc (fixes #158)
  https://github.com/shimmerproject/Greybird/commit/0a0853f.patch

missing in Greybird 3.20.1.

Greybird 3.22.0 is already in Fedora 25 and 26,
https://koji.fedoraproject.org/koji/packageinfo?packageID=13978

but for Fedora 24 driven by GTK+ 3.20, Greybird 3.20.1 needs mentioned patches.
Comment 14 poma 2016-12-16 21:52:41 CET
Created attachment 6929 
Notebooks maximus redux - GTK+ 3.20.9
Comment 15 poma 2016-12-16 21:54:36 CET
Created attachment 6930 
Notebooks maximus redux - GTK+ 3.22.5
Comment 16 Igor editbugs 2016-12-21 13:15:38 CET
https://git.xfce.org/apps/xfce4-terminal/commit/?id=763bd8fce3ab3c2bf039852eed507529423d54e0 adds a new hidden option: MiscSlimTabs. If set to TRUE (disabled by default), it will override tabs style with my CSS that I've posted here, and make tabs slim.
Comment 17 Kevin Fenzi 2016-12-21 17:18:09 CET
Igor: thanks! 

is a new release planned anytime soon? Or should I backport this for testing?
Comment 18 Igor editbugs 2016-12-21 18:17:28 CET
Kevin, yes, I'm planning another release this year, just would like something else to get into it.

But, I'm always willing to receive an early feedback so if you could backport the mentioned commit and the next one after it (which makes the style change specific to terminal tabs, not affecting others), this would be just perfect.
I only wonder: will your users notice the change, for it's not enabled be default?
Comment 19 poma 2016-12-22 10:45:51 CET
Created attachment 6932 
xfce4-terminal GtkTreeView

How about put all current and future "Misc*", eventually a "Shortcuts*",
be they default as TRUE or FALSE, in a GtkTreeView i.e. GtkListStore format,
as is done with "Default Icons" in Xfdesktop.

Besides all options are within reach for users,
in this way there is no need to worry about the increasing height of the preferences window.


Ref.
https://developer.gnome.org/gtk3/stable/GtkTreeView.html
https://git.xfce.org/users/eric/xfdesktop/log/?h=the-long-road-to-gtk3
Comment 20 Igor editbugs 2016-12-22 11:46:20 CET
(In reply to poma from comment #19)
> Created attachment 6932 
> xfce4-terminal GtkTreeView
> 
> How about put all current and future "Misc*", eventually a "Shortcuts*",
> be they default as TRUE or FALSE, in a GtkTreeView i.e. GtkListStore format,
> as is done with "Default Icons" in Xfdesktop.
> 
> Besides all options are within reach for users,
> in this way there is no need to worry about the increasing height of the
> preferences window.
> 
> 
> Ref.
> https://developer.gnome.org/gtk3/stable/GtkTreeView.html
> https://git.xfce.org/users/eric/xfdesktop/log/?h=the-long-road-to-gtk3

This looks like an interesting idea, thanks poma!
Comment 21 Kevin Fenzi 2016-12-23 00:04:27 CET
(In reply to Igor from comment #18)
> Kevin, yes, I'm planning another release this year, just would like
> something else to get into it.
> 
> But, I'm always willing to receive an early feedback so if you could
> backport the mentioned commit and the next one after it (which makes the
> style change specific to terminal tabs, not affecting others), this would be
> just perfect.
> I only wonder: will your users notice the change, for it's not enabled be
> default?

I think the ones that really want the smaller tabs will be able to set it sure. 

Will see about a test package for them, or just the next release if I don't get to it until then. Thanks.
Comment 22 Kevin Fenzi 2017-01-03 17:15:31 CET
This doesn't seem to be working too well sadly. One downstream person is seeing a slight change, and another sees no change at all. ;( I am not sure how to debug this. ;( 

Can you take a look at the downstream bug? https://bugzilla.redhat.com/show_bug.cgi?id=1369002
Comment 23 Igor editbugs 2017-01-04 10:47:17 CET
Kevin, I've registered an account on Red Hat bugzilla and joined the conversation.
Comment 24 Philip Rhoades 2017-01-17 11:00:30 CET
I have given up on waiting for this problem to be sorted out - I bit the bullet and started using tmux which, with a little learning, allows much more sophisticated use of a single terminal interface and now I don't have to worry about terminal tabs at all . .
Comment 25 Igor editbugs 2017-01-17 11:10:29 CET
(In reply to Philip Rhoades from comment #24)
> I have given up on waiting for this problem to be sorted out - I bit the
> bullet and started using tmux which, with a little learning, allows much
> more sophisticated use of a single terminal interface and now I don't have
> to worry about terminal tabs at all . .

I've added a config option to show smaller tabs: https://bugzilla.xfce.org/show_bug.cgi?id=12796#c16.

Nevertheless, I'm very happy that you've found your ideal terminal app.

Bug #12796

Reported by:
Philip Rhoades
Reported on: 2016-08-29
Last modified on: 2017-01-17
Duplicates (1):

People

CC List:
6 users

Version

Version:
0.6.90

Attachments

Additional information