! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
GTK+ 3 port - dependency issue - Exo GTK+ 3 port
Status:
RESOLVED: INVALID
Priority:
Very High
Severity:
blocker
Product:
Xfce4-whiskermenu-plugin
Component:
General

Comments

Description poma 2016-08-22 12:06:07 CEST
$ git log -1
commit 08e72c72c5a2b6102bf933bca159ba907bac094d
Author: Graeme Gott <graeme@gottcode.org>
Date:   Sat Aug 20 12:07:20 2016 -0400

    Add git version number.

$ cmake -DCMAKE_INSTALL_PREFIX=/usr ..
-- The C compiler identification is GNU 6.1.1
-- The CXX compiler identification is GNU 6.1.1
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29") 
-- Checking for module 'gtk+-3.0'
--   Found gtk+-3.0, version 3.20.9
-- Checking for module 'exo-2>=0.11'
--   
CMake Error at /usr/share/cmake/Modules/FindPkgConfig.cmake:363 (message):
  A required package was not found
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPkgConfig.cmake:528 (_pkg_check_modules_internal)
  panel-plugin/CMakeLists.txt:17 (pkg_check_modules)


-- Configuring incomplete, errors occurred!
See also "/tmp/xfce4-whiskermenu-plugin/build/CMakeFiles/CMakeOutput.log".
Comment 1 Graeme Gott editbugs 2016-08-22 13:57:06 CEST
This isn't a bug in Whisker Menu. You simply need the most recently released exo, version 0.11 (which the GTK+ 3 version of compiles and works just fine despite deprecation warnings).
Comment 2 poma 2016-08-22 19:48:01 CEST
xfce4-whiskermenu-plugin git master doesn't builds against exo git master,
as simple as that.

Until this is resolved, do not touch.
Comment 3 poma 2016-08-22 19:56:42 CEST
Besides that shit, with yours forcing on REQUIRED exo-2>=0.11,
you are indirectly contributing to Thunar breakage.
Comment 4 Graeme Gott editbugs 2016-08-22 21:14:41 CEST
Again, this is NOT a bug in Whisker Menu. There is nothing wrong with the Whisker Menu git master! The output quoted in the bug report is simply cmake saying "I can't find a valid version of exo".

You enabled turning warnings into errors (which prevents exo from compiling), then did not install exo because it failed to build, so of COURSE cmake can't find it! Are you going to open a pointless bug for EVERY project that depends on exo whenever exo git master has a problem?

And, just a FYI, exo git master compiles just fine if you use --disable-debug, which doesn't turn warnings into errors. And if you do that, surprise surprise, Whisker Menu git master compiles just fine against exo git master.

Finally, Thunar having issues is not going to stop me from updating Whisker Menu to be GTK+ 3. Thunar simply has to be fixed. And if you don't want to use a GTK+ 3 version of Whisker Menu, you can just 1.6 which supports exo < 0.11.
Comment 5 Graeme Gott editbugs 2016-08-22 23:25:18 CEST
Upon reflection, I wish I had taken the time to remove the snark from my response. I still stand by my position that this is a wholly unnecessary bug report, as all it says is that it can't find exo, and when you compile exo with --disable-debug and install it, the bug goes away. However, I did not need to be rude, and I apologize for that.

Bug #12782

Reported by:
poma
Reported on: 2016-08-22
Last modified on: 2016-08-22

People

Assignee:
Graeme Gott
CC List:
0 users

Version

Attachments

Additional information