Created attachment 6777 patch Hello, Patch adds a popover window where you can select a color for a tab and a title pattern. If pattern will be matched on any tab, selected color will be applied. Patch is still missing an ability to save settings to the disk, but I think it could be landed separately later.
Hi Alexander, and thanks for the patch! Unfortunately, it is incomplete: terminal_screen_set_tab_color() declaration is missing from terminal-screen.h. Also, after I've compiled it, it's failing with the following: (xfce4-terminal:20042): GLib-GObject-WARNING **: g_object_get_valist: object class 'TerminalPreferences' has no property named 'tab-colors-list' Segmentation fault (core dumped)
Created attachment 6783 second try full patch
im sorry, wrong merge :)
Thanks, the 2nd try is better :) However, I can see some issues: - when opening a set color dialog, the title in the input field does not match the actual tab title; - when color setting is applied, it gets changed on the active tab only; would be nice to apply the color to all matching tabs at once; - when changing input to a non-matching text, the tab color remains unchanged; would be nice to reset it to default (black) color.
- when opening a set color dialog, the title in the input field does not match the actual tab title; I dont have this issue. I have tried with custom title and without. Can i have a screenshot or something to see where is the problem? - when color setting is applied, it gets changed on the active tab only; would be nice to apply the color to all matching tabs at once; i have fixed that - when changing input to a non-matching text, the tab color remains unchanged; would be nice to reset it to default (black) color. How can i reproduce that? Here when title changes to different one rather then defined, im getting default black color
Created attachment 6802 third try
now when im thinking about this, i think the best way will be to match tab text color with a prompt color. now need to figure out how to parse this \033 escape chars. Any clue how to do that?
-- GitLab Migration Automatic Message -- This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/apps/xfce4-terminal/-/issues/14. Please create an account or use an existing account on one of our supported OAuth providers. If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev