! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Autocomplete should be case insensitive
Status:
RESOLVED: FIXED
Severity:
enhancement

Comments

Description R. Diez 2016-08-07 17:16:12 CEST
When autocompleting a file path in the location bar, the matching should be case-insensitive, like in Dolphin File Manager. Or at least there should be an option to turn the matching to case insensitive.
Comment 1 Pim Pronk 2017-01-10 19:40:00 CET
Created attachment 6954 
Patch implementing case-insensitive search

Although its impossible to do full locale-independent case-insensitive matching/sorting, unicode case folding provides a method to do this. This patch implements a case-insensitive search by converting the search term & path entry with g_utf8_casefold()
Comment 2 alexxcons editbugs 2018-03-02 21:59:46 CET
Thanks for the patch and sorry for the late reply !

I did not look into other locals, however for me the search ( CTRL + F ) already is case insensitive ( thunar 1.6.14), though I dont know where the magic currently happens. Possibly there is some use-case which is not covered by the current case insensitive on the search ?

Despite from that, this issue is about auto-complete in the location bar, not about the search ;)
Comment 3 Pim Pronk 2018-03-14 09:59:29 CET
To be honest, I am not sure anymore which problem I was trying to solve over a year ago ;)

Anyway I just noticed that I am still runing an old 1.6.10-git version of Thunar, so I will upgrade to the latest release and see if my other list of bugs/features have been resolved in the mean time. Thanks.
Comment 4 Theo Linkspfeifer editbugs 2020-02-19 20:27:14 CET
The patch enables case independent matching, but it breaks auto completion.
Comment 5 Theo Linkspfeifer editbugs 2020-03-10 18:55:56 CET
Created attachment 9564 
quick diff

This seems to work.
Comment 6 alexxcons editbugs 2020-03-11 23:49:41 CET
Patch works nice here, thanks Theo !

I only would rename the arguments of "thunar_path_entry_has_prefix_casefolded" to better reflect their purpose .. e.g:
thunar_path_entry_has_prefix_casefolded (const gchar *string, const gchar *prefix)

Besides that, looks good to me to get pushed
Comment 7 Theo Linkspfeifer editbugs 2020-03-13 14:33:15 CET
Created attachment 9591 
patch
Comment 8 Git Bot editbugs 2020-03-13 22:00:26 CET
Theo Linkspfeifer referenced this bugreport in commit c58510b4851f62cf8dac6233df140e3f6c19d4ca

Make path entry matching case-insensitive (Bug #12747)

https://git.xfce.org/xfce/thunar/commit?id=c58510b4851f62cf8dac6233df140e3f6c19d4ca
Comment 9 alexxcons editbugs 2020-03-13 22:01:33 CET
Pushed to master,

thank you for your contribution !
Comment 10 R. Diez 2020-03-15 13:22:28 CET
I am the original reported. I just wanted to thank you for this improvement.

Bug #12747

Reported by:
R. Diez
Reported on: 2016-08-07
Last modified on: 2020-03-15

People

Assignee:
Xfce Bug Triage
CC List:
5 users

Version

Version:
1.6.10

Attachments

Patch implementing case-insensitive search (1.17 KB, patch)
2017-01-10 19:40 CET , Pim Pronk
no flags
quick diff (1.74 KB, patch)
2020-03-10 18:55 CET , Theo Linkspfeifer
no flags
patch (2.12 KB, patch)
2020-03-13 14:33 CET , Theo Linkspfeifer
no flags

Additional information