! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Volume change notifications cover volume controls (xfce4-pulseaudio-plugin) w...
Status:
RESOLVED: FIXED
Product:
Xfce4-pulseaudio-plugin
Component:
General

Comments

Description Michał Górny 2016-07-31 17:22:42 CEST
Created attachment 6761 
Sloppy screenshot ;-)

Since xfce4-notifyd 0.3.0, the volume change notifications appear on top of volume controls brought by xfce4-pulseaudio-plugin. As a result, when I try to slide the volume bar the notification popup appear on top of it and causes the slider to lose focus (and therefore no longer be scrolled even though I'm holding the mouse button). I'm attaching the screenshot that would helpfully help my explanation ;-).

In previous versions, the volume change notifications did appear below (as in z-index) the volume controls.
Comment 1 Simon Steinbeiss editbugs 2016-08-30 10:39:55 CEST
This is likely a problem that should be resolved in the plugin, not the notification daemon as other plugins (xfce4-clipman-plugin from git master, which is gtk3 or xfce4-power-manager-plugin) which are also Gtk+3 don't have this issue.

Andrzej, what's your take on this?
Comment 2 Andrzej editbugs 2016-08-31 01:05:37 CEST
At some point I may go back to issuing notifications only when Volume Up/Down/Mute keys are pressed. Currently notifications are shown at any output volume change, which fixes some corner cases of the previous solution but results in unnecessary notifications like the one in this report.

Can't commit to any dates though.

BTW, notifications can be disabled in the plugin preferences.
Comment 3 Michał Górny 2016-08-31 06:52:15 CEST
I actually like having notifications of any volume changes (i.e. the plugin telling me that something is fiddling with the volume). What I report is that with notifyd < 0.3.0, the notifications appear below plugin, and starting with 0.3.0 they suddenly are on top of it.
Comment 4 Andrzej editbugs 2016-08-31 09:12:54 CEST
(In reply to Michał Górny from comment #3)
> I actually like having notifications of any volume changes (i.e. the plugin
> telling me that something is fiddling with the volume). What I report is
> that with notifyd < 0.3.0, the notifications appear below plugin, and
> starting with 0.3.0 they suddenly are on top of it.

I see, I missed your comment about "z-index". If so that could be something to look at in notifyd, I don't think stacking order has anything to do with the plugin. Simon?

The issue with the plugin is that the notifications should not/doesn't need to be shown when the volume is changed via the plugin's popup menu. This is what I looked at before but because of the asynchronous nature of libpulseaudio API it is a bit fiddly to implement.
Comment 5 Michał Górny 2016-08-31 16:44:34 CEST
(In reply to Andrzej from comment #4)
> The issue with the plugin is that the notifications should not/doesn't need
> to be shown when the volume is changed via the plugin's popup menu. This is
> what I looked at before but because of the asynchronous nature of
> libpulseaudio API it is a bit fiddly to implement.

Wouldn't it be possible to disable sending notifications when the plugin's popup is open? This would cover the changes done via plugin's popup, and would still keep desired notifications when volume is changed via scrolling over the notification area icon. It would also hide notifications for changes via other tools when the popup is open -- but then, the volume slider would indicate the changes anyway.
Comment 6 Simon Steinbeiss editbugs 2016-08-31 18:39:54 CEST
> I see, I missed your comment about "z-index". If so that could be something to > look at in notifyd, I don't think stacking order has anything to do with the
> plugin. Simon?

Well I think maybe something changed because Gtk3 may set different window types (in the ewmh sense), at least that was a hint that Olivier dropped when I asked him.
Most other Gtk+3 plugins (e.g. indicator-sound, xfce4-power-manager, xfce4-clipman-plugin) grab the input and consequently the volume keys don't spawn notifications.


> Wouldn't it be possible to disable sending notifications when the plugin's
> popup is open? This would cover the changes done via plugin's popup, and
> would still keep desired notifications when volume is changed via scrolling
> over the notification area icon. It would also hide notifications for
> changes via other tools when the popup is open -- but then, the volume
> slider would indicate the changes anyway.

This is exactly what I would propose and why I moved this bugreport over to the plugin in the first place ;)
Comment 7 Andrzej editbugs 2016-09-03 10:57:34 CEST
This should be now fixed in git master. Are you able to test it?
Comment 8 Michał Górny 2016-09-03 13:33:15 CEST
(In reply to Andrzej from comment #7)
> This should be now fixed in git master. Are you able to test it?

I can confirm that popup notification no longer appears when changing volume via the slider.

It appears though when 'mute' checkbox is checked/unchecked but it's unclear to me if that's desired or not. It doesn't cause any trouble since the dialog is disappearing on that event anyway, and probably it's not worth the effort to think about it more.

So I'd say it's fixed and I'm happy now ;-).
Comment 9 Andrzej editbugs 2016-09-03 22:01:38 CEST
Yes, both mute and unmute trigger the notification because by the time the volume changes the menu is already closed. I'll leave it as is, it may be desirable to have the notification in this case.

I'm closing this report as fixed.

Bug #12736

Reported by:
Michał Górny
Reported on: 2016-07-31
Last modified on: 2016-09-03

People

Assignee:
Andrzej
CC List:
1 user

Version

Version:
unspecified

Attachments

Sloppy screenshot ;-) (87.59 KB, image/png)
2016-07-31 17:22 CEST , Michał Górny
no flags

Additional information