! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
exo-csource is required to build mousepad in maintainer mode
Status:
RESOLVED: FIXED
Product:
Mousepad
Component:
General

Comments

Description Igor editbugs 2016-07-21 10:38:39 CEST
Created attachment 6744 
configure.ac.in patch

Patch attached.
Comment 1 Matthew Brush editbugs 2016-07-21 16:27:26 CEST
Looks OK at a glance. The only thing I'd change is to use AS_MSG_ERROR() rather than echo/exit commands, but it's not really important, and I didn't look to see which way the existing checks do it.
Comment 2 Igor editbugs 2016-07-21 16:29:57 CEST
I just pulled it from xfce4-notifyd as gaston suggested.
Comment 3 Matthew Brush editbugs 2016-07-22 01:59:27 CEST
(In reply to Igor from comment #2)
> I just pulled it from xfce4-notifyd as gaston suggested.

It's probably fine, I suppose most shells probably have some kind of builtins or separate utilities for `echo` and `exit`, it just seems a little nicer using the Autoconf macros to be sure. No biggie, I'll look at it closer when I merge this.
Comment 4 Git Bot editbugs 2019-05-18 23:37:15 CEST
Igor referenced this bugreport in commit 595b3a572cea618d2fa87506860ab3d01fddd0f6

Check for exo-csource in maintainer mode (Bug #12719)

https://git.xfce.org/apps/mousepad/commit?id=595b3a572cea618d2fa87506860ab3d01fddd0f6
Comment 5 Andre Miranda editbugs 2019-05-18 23:37:46 CEST
LGTM, thanks.
Comment 6 Igor editbugs 2019-05-19 16:27:36 CEST
Thanks for merging!

I'd completely forgotten about this patch and was so surprised seeing I committed something. ;)

Bug #12719

Reported by:
Igor
Reported on: 2016-07-21
Last modified on: 2019-05-19

People

Assignee:
Matthew Brush
CC List:
2 users

Version

Target Milestone:
Mousepad 0.2.x

Attachments

configure.ac.in patch (1.13 KB, patch)
2016-07-21 10:38 CEST , Igor
no flags

Additional information