! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Changing view type delete history
Status:
RESOLVED: FIXED

Comments

Description kaillasse91 2016-07-18 15:06:01 CEST
Steps :

mkdir -p /tmp/folder1/folder2

open thunar, go in /tmp/folder1

go into a /tmp/folder1/folder2

change view type: detailed view -> icon view

try to go back with Go/Back menu

expected behaviour : going back in folder1 (or if changing view invalidate history, to have Go/Back to be greyed, inactivated)

current behaviour : we stay in folder2



$ apt-cache show thunar | grep -i version
Version: 1.6.10-2ubuntu1
$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 16.04 LTS
Release:	16.04
Codename:	xenial
Comment 1 Adam Purkrt 2016-09-18 22:08:01 CEST
Created attachment 6855 
thunar-history-after-view-change-fix.patch

Attached is a fix. It deletes the extra history copying in thunar_window_action_view_changed function, which apparently caused the problem.

The history already gets copied in thunar_window_notebook_insert function.
Comment 2 Harald Judt editbugs 2016-10-11 23:14:40 CEST
Fixed in https://git.xfce.org/xfce/thunar/commit/?id=9578e0dec5cee473222cb813b43de31067c604e2

According to my tests, this should work and not introduce any regressions. I just hope I haven't missed something.

Bug #12708

Reported by:
kaillasse91
Reported on: 2016-07-18
Last modified on: 2017-05-09

People

Assignee:
Xfce Bug Triage
CC List:
4 users

Version

Version:
unspecified

Attachments

Additional information