! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Left-clicking on an item in tasklist doesn't raise it if it has focus
Status:
RESOLVED: MOVED
Product:
Xfce4-panel
Component:
Window Buttons

Comments

Description xfce 2016-07-16 22:14:47 CEST
I use focus-follows-mouse with raise-on-focus turned off.  On a cluttered desktop, I normally will left-click a window in the tasklist in order to (1) restore it (if it's minimized) and (2) raise it.  I came to depend on this behavior from many years of using KDE, and it seems Xfce works essentially the same, but there seems to be a bug with it in one situation:

If the window button that I left-click on currently has focus (because it was the last window I rolled over when moving my mouse to the panel), then it won't get raised.  I assume that this must be a bug, as it doesn't make much sense that someone using focus-follows-mouse would want a window not to be raised on left-click just because that window happened to be the last one their mouse rolled over before the pointer got into the panel.

In case anything isn't clear, there is some additional discussion of this between myself and ToZ at: 
https://forum.xfce.org/viewtopic.php?id=10977

Also, I recorded a video of the problem at:
https://www.youtube.com/watch?v=YukSJZTgBBs
(Note how the first time I left-click on Thunderbird's tasklist entry, it doesn't get raised because my mouse hit it on the way up; but the second time I left-click it, it does, because I avoided it on the way up)
Comment 1 xfce 2016-07-16 22:33:16 CEST
Forgot to mention, this problem also requires that "Middle click action" be set to "Minimize Window".
Comment 2 Titon Barua 2017-04-12 07:01:44 CEST
I can confirm this bug. Reporting from Ubuntu 16.04, Xfce 4.12. "Window buttons" behavior becomes buggy when "Middle Click Action" is set to "Minimize window".

Normal behavior: Left click raises minimized windows.
Buggy behavior: Left click on minimized windows does nothing.
Comment 3 xfce 2017-07-20 09:55:51 CEST
Created attachment 7233 
Patch to xfce4-panel-4.12.1/plugins/tasklist/tasklist-widget.c
Comment 4 xfce 2017-07-20 09:56:17 CEST
Bug still exists in 4.12.1.  I attached the patch that I've been using to fix the issue for myself.
Comment 5 xfce 2018-11-04 06:43:20 CET
Still exists in 4.13.3.
Comment 6 mailinglists35 2018-12-12 01:12:02 CET
I think this is a duplicate of #12186 and the root cause it that currently "window buttons" item in xfce4 panel - aka "the taskbar" in windows os language - indicates the focused window, while we need it to indicate the raised window.
Comment 7 xfce 2018-12-12 01:16:49 CET
I'm not so sure that this is related to that bug.  This one seems like a very simple logic error in the code to me.  Check out the patch I posted, it fixes this problem.
Comment 8 xfce 2019-06-25 07:50:49 CEST
Created attachment 8682 
Fix for this issue in 4.13.5

Issue still exists in 4.13.5.  New patch attached as the relevant code changed a bit.
Comment 9 xfce 2019-08-24 13:09:37 CEST
Still present in 4.14.
Comment 10 Git Bot editbugs 2020-05-28 02:01:06 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfce4-panel/-/issues/157.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #12705

Reported by:
xfce
Reported on: 2016-07-16
Last modified on: 2020-05-28

People

Assignee:
Nick Schermer
CC List:
2 users

Version

Version:
4.14.0

Attachments

Additional information