! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[Patch] Port xfce4-mixer to GTK+3
Status:
RESOLVED: FIXED
Product:
Xfce4-mixer
Component:
General

Comments

Description Mike Gelfand 2016-07-05 16:44:12 CEST
I've made an attempt to port xfce4-mixer to GTK+3 (3.14+, as currently set in Xfce 4.14 roadmap): https://github.com/xfce-mirror/xfce4-mixer/compare/master...mikedld:gtk3-port

Not sure about specific library versions in configure.ac.in, as well as overall code quality (I'm not developing with GTK+ much). Please review.
Comment 1 Landry Breuil editbugs 2016-07-05 21:42:18 CEST
Tested it here, works fine, cool stuff !
Remaining todo:

* migrate to gtkapplication/gapplication and drop libunique dependency
* migrate GtkAction to GAction in xfce-mixer-window.c

But lots have already been done, keep up the good work :)
Comment 2 Mike Gelfand 2016-07-06 16:55:30 CEST
(In reply to Landry Breuil from comment #1)
> * migrate to gtkapplication/gapplication and drop libunique dependency
> * migrate GtkAction to GAction in xfce-mixer-window.c
Done with second commit.
Comment 3 Landry Breuil editbugs 2016-07-07 08:26:18 CEST
Wow, awesome - at this point, i think we'll just merge it to master, and removing dbus-glib dependency can still be done later on.
Comment 4 Landry Breuil editbugs 2016-07-08 21:24:18 CEST
Thanks a lot again, merged to master in http://git.xfce.org/apps/xfce4-mixer/commit/?id=a12e53cda395aad85316181761b21b770b90f601 !

Bug #12683

Reported by:
Mike Gelfand
Reported on: 2016-07-05
Last modified on: 2016-07-08

People

Assignee:
Jannis Pohlmann
CC List:
1 user

Version

Version:
Unspecified

Attachments

Additional information