panel label sets properly once it is toggled but does not apply properly after logging out and logging again although selected "on" is blue .. shows in panel once toggled off and on again .. I have multiple copies running in the panel so it is nice to see the labels properly ..
Hm, probably something i missed when converting to gtk3.. is it with current git master, or the .99 release ?
appears I have the 4.99 version installed .. I think I had trouble using the git version .. but I've just reinstalled the git version .. now to test with it too!
actually both the current git version and the 4.99 version have the issue .. I'm wondering if the toggles are backwards
but you have to flip them from blue on to grey off to blue on for the labels to show once you've logged in .. at login it shows blue on but no label shows viewing the settings menu for it is also a challenge you have to go through the panel-preferences instead via items to edit it as the thin border is not always easy to left click .. especially in the git version .. the 4.99 version did seem to allow easier border use
more border testing .. they are about the same .. just as trick to select
Right now 4.99 and git are equivalent, so that's normal if the behaviour is the same. I'll try to look into that issue soon, that's probably an oversight when converting to GtkSwitch in http://git.xfce.org/panel-plugins/xfce4-smartbookmark-plugin/commit/?id=7f0fc7d5b3c2ff33985c166633d50f292f34e596, as the semantic of the latter is the opposite of GtkToggleButton. As a first idea, can you readd a ! in the if on this line: http://git.xfce.org/panel-plugins/xfce4-smartbookmark-plugin/tree/src/smartbookmark.c#n106 That got reversed in the said commit, and i wonder if the issue isn't here..
yes that works toggle makes more sense now too! clicking on the blue on actually turns it on the label .. and it sticks on logout and then the label re-appears at login as was expected .. thank you ..
Turns out this is a bit more complicated, since the logic to set the GtkEntry to fill the label is reversed too... ah, if only the semantic was 'show label' and not 'hide label'.... oh well, while here, will simplify a bit the code.
Okay, should work properly in git master now, the commit fixing it being http://git.xfce.org/panel-plugins/xfce4-smartbookmark-plugin/commit/?id=060fa1d41be2416b8170e2d9d5015d7860beb66a - can you confirm it ?
looks like you broke it .. I was previously able to paste a bug number in the entry field and it would go directly too it now it does this "https://bugzilla.xfce.org/12666" which gives a 404 Actually getting to the bug requires this: https://bugzilla.xfce.org/show_bug.cgi?id=12666 mmh the bugzilla.xfce.org website has stopped accepting the bug number directly.. as the 4.99 version also dies this way.. but setting the URL to https://bugzilla.xfce.org/show_bug.cgi?id= works .. my default setting is currently for http:\\bugs.gentoo.org with label BTS changed by a sed line in place substitution at build from the original debian.org default this works properly .. current saved version is https and labeled gentoo .. using the current git version: I tried to remove the xfce version and re-add it and I can not get the default text fields to stick now .. the previous version allowed these fields to be edited at will.. so the real error now is that any edits to the label and URL fields are no longer being saved in the git version at present .. change one thing .. break another .. sigh ..
to clarify .. trying to change the default text fields label and url no longer works .. they stay at the defaults.. will not save at the close in the current git version
note: any existing settings will continue to work .. just new entries are impossible to change from the "default" .. as well.. changes to already existing entries are also impossible..
okay discovered that the settings are stored in .config/xfce4/panel/smartbookmark-??.rc files the ?? being a reference number .i.e. 24 or 23 .. etc. these can be edited provided xfce4 is not running .. and their contents will be used on the next login .. a kludge at best .. but a temporary work around if needed
Ok, i'll relook at it tonight. Not enough testing on my side..
http://git.xfce.org/panel-plugins/xfce4-smartbookmark-plugin/commit/?id=4ef680fdfea8cc7967ae5c1b2f28f1de9f11c00d should fix it - thinko on my side, was using the wrong signal.
yup that works .. great work .. thanks I'll let you know if i find any other issues..:)
Great, thanks for your feedback on debugging this :)