Horizontal spanning happens during: - Open/Close Tab - toggle: Show Menubar/Toolbar Screencast: http://goo.gl/Gm4ffO vids/
Seen on both, GTK+ 3.20.6 and 3.16.7
Yes, this is a known issue. Could you please try my private repo version? https://github.com/f2404/xfce4-terminal3 I did a small change that seems to resolve the issue on my machine.
(In reply to Igor from comment #2) > Yes, this is a known issue. > Could you please try my private repo version? > https://github.com/f2404/xfce4-terminal3 > I did a small change that seems to resolve the issue on my machine. https://github.com/f2404/xfce4-terminal3/commit/7e60f5c.patch It resolves horizontal spanning, but introduces vertical shrinkage, tested with GTK+ 3.16.7
I'm observing no shrinkage on Arch Linux with gtk 3.20.6... what system are you running?
Also, when are you seeing it - when adding/closing tabs?
(In reply to poma from comment #3) > (In reply to Igor from comment #2) > > Yes, this is a known issue. > > Could you please try my private repo version? > > https://github.com/f2404/xfce4-terminal3 > > I did a small change that seems to resolve the issue on my machine. > > https://github.com/f2404/xfce4-terminal3/commit/7e60f5c.patch > > It resolves horizontal spanning, but introduces vertical shrinkage, > tested with GTK+ 3.16.7 Works OK for GTK+ 3.20.6
(In reply to Igor from comment #4) > I'm observing no shrinkage on Arch Linux with gtk 3.20.6... what system are > you running? Fedora 22 - GTK+ 3.16.7 Fedora 24 - GTK+ 3.20.6
(In reply to Igor from comment #5) > Also, when are you seeing it - when adding/closing tabs? With: https://github.com/f2404/xfce4-terminal3/commit/7e60f5c.patch and GTK+ 3.16.7 vertical shrinkage happens during: - Open/Close Tab - toggle: Show Menubar/Toolbar
Ok, so it seems I can keep this resizing function for gtk<3.20 and remove it for gtk>=3.20. Thanks for testing it!
Or no - the issue will be resolved for gtk3.20 but I will still have to deal with it for 3.16. Oh.
(In reply to Igor from comment #10) > Or no - the issue will be resolved for gtk3.20 but I will still have to deal > with it for 3.16. Oh. Also tested GTK+ 3.18.9 on Fedora 23, with or without: https://github.com/f2404/xfce4-terminal3/commit/7e60f5c.patch the symptoms are the same as with GTK+ 3.16.7 so the bar is setted correctly - GTK+ >= 3.20.6
GTK+-logia on the resizing issue, with applied: https://github.com/f2404/xfce4-terminal3/commit/7e60f5c.patch OK: ... - 3.19.12 - 3.19.11 - 3.19.10 - 3.19.9 - 3.19.8 - 3.19.7 - 3.19.6 - 3.19.5 - 3.19.4 - 3.19.3 - 3.19.2 ---------- BROKEN: - 3.19.1 * - 3.18.9 ... * vertical shrinkage happens during: - Open/Close Tab - toggle: Show Toolbar - not with Show Menubar
http://git.xfce.org/apps/xfce4-terminal/commit/?id=9ae3930 http://git.xfce.org/apps/xfce4-terminal/tree/terminal/terminal-screen.c#n1751 #if GTK_CHECK_VERSION (3,20,0) // Don't need this on gtk>=3.20 return; #endif Whether to comment: // Need this on gtk>=3.20 or more precisely: // Need this on GTK+ >= 3.19.2 I'm talking about affirmation, in contrary to negation as is stated
And there are 524 patches between 1st working release - gtk-3.19.2 and last broken release - gtk-3.19.1 0524-3.19.2.patch ... 0001-Drop-some-no-longer-existing-headers.patch to consider - just to see, where and why it broke. cara mamma
(In reply to poma from comment #14) > And there are 524 patches between 1st working release - gtk-3.19.2 > and last broken release - gtk-3.19.1 > > 0524-3.19.2.patch > ... > 0001-Drop-some-no-longer-existing-headers.patch > > to consider - just to see, where and why it broke. > > cara mamma Whichever GTK+ commit in this range was built, subsequently against it xfce4-terminal patched with: https://github.com/f2404/xfce4-terminal3/commit/7e60f5c.patch it worked without resizing issue.
(In reply to poma from comment #15) > (In reply to poma from comment #14) > > And there are 524 patches between 1st working release - gtk-3.19.2 > > and last broken release - gtk-3.19.1 > > > > 0524-3.19.2.patch > > ... > > 0001-Drop-some-no-longer-existing-headers.patch > > > > to consider - just to see, where and why it broke. > > > > cara mamma > > > Whichever GTK+ commit in this range was built, > subsequently against it xfce4-terminal patched with: > https://github.com/f2404/xfce4-terminal3/commit/7e60f5c.patch > it worked without resizing issue. Yeah, diff is with distro provided bins and ones locally built, and gtk-3.19.2 https://git.gnome.org/browse/gtk+/commit/?id=5018e32 is 1st working release - tested on Fedora 23/4, with commits http://git.xfce.org/apps/xfce4-terminal/commit/?id=9ae3930 http://git.xfce.org/apps/xfce4-terminal/commit/?id=623664b redefined to gtk-3.19.2 So these are the reference points Git: the final frontier. These are the voyages of the Xfce4 Terminal. Its twelve-year mission: to explore strange new commits, to seek out new patch and new contributions, to boldly go where no terminal has gone before.
Created attachment 6759 Fix width size when new tabs are created With GTK+ 3.18.8 new tabs expand window size. I use this patch to fix the width resize. Tested only with GTK+ 3.18 (3.20 is not yet available in FreeBSD).
(In reply to duchateau.olivier from comment #17) > Created attachment 6759 > Fix width size when new tabs are created > > With GTK+ 3.18.8 new tabs expand window size. I use this patch to fix the > width resize. > > Tested only with GTK+ 3.18 (3.20 is not yet available in FreeBSD). Tested with GTK+ 3.18.9 (Fedora 23): - 0001-Fix-resize-logic-with-tab.patch resolves resizing (horizontal spanning) issue Tested with GTK+ 3.20.6 (Fedora 24): - 0001-Fix-resize-logic-with-tab.patch does not break already resolved resizing issue Tested with GTK+ 3.16.7 (Fedora 22 - EOL 2016-07-19) - 0001-Fix-resize-logic-with-tab.patch resolves resizing (horizontal spanning) issue however it introduces vertical shrinkage
(In reply to poma from comment #18) > (In reply to duchateau.olivier from comment #17) > > Created attachment 6759 > > Fix width size when new tabs are created > > > > With GTK+ 3.18.8 new tabs expand window size. I use this patch to fix the > > width resize. > > > > Tested only with GTK+ 3.18 (3.20 is not yet available in FreeBSD). > > Tested with GTK+ 3.18.9 (Fedora 23): > - 0001-Fix-resize-logic-with-tab.patch > resolves resizing (horizontal spanning) issue > > Tested with GTK+ 3.20.6 (Fedora 24): > - 0001-Fix-resize-logic-with-tab.patch > does not break already resolved resizing issue > > Tested with GTK+ 3.16.7 (Fedora 22 - EOL 2016-07-19) > - 0001-Fix-resize-logic-with-tab.patch > resolves resizing (horizontal spanning) issue > however it introduces vertical shrinkage Patch works (with Gtk+ >= 3.20) if you remove this code (in 'terminal_screen_force_resize_window' method)? // Don't need this on gtk>=3.20 #if GTK_CHECK_VERSION (3,20,0) return; #endif
(In reply to duchateau.olivier from comment #19) > (In reply to poma from comment #18) > > (In reply to duchateau.olivier from comment #17) > > > Created attachment 6759 > > > Fix width size when new tabs are created > > > > > > With GTK+ 3.18.8 new tabs expand window size. I use this patch to fix the > > > width resize. > > > > > > Tested only with GTK+ 3.18 (3.20 is not yet available in FreeBSD). > > > > Tested with GTK+ 3.18.9 (Fedora 23): > > - 0001-Fix-resize-logic-with-tab.patch > > resolves resizing (horizontal spanning) issue > > > > Tested with GTK+ 3.20.6 (Fedora 24): > > - 0001-Fix-resize-logic-with-tab.patch > > does not break already resolved resizing issue > > > > Tested with GTK+ 3.16.7 (Fedora 22 - EOL 2016-07-19) > > - 0001-Fix-resize-logic-with-tab.patch > > resolves resizing (horizontal spanning) issue > > however it introduces vertical shrinkage > > Patch works (with Gtk+ >= 3.20) if you remove this code (in > 'terminal_screen_force_resize_window' method)? > > // Don't need this on gtk>=3.20 > #if GTK_CHECK_VERSION (3,20,0) > return; > #endif For both - GTK+ 3.20.6 and 3.18.9, no need to remove GTK_CHECK_VERSION just apply your - 0001-Fix-resize-logic-with-tab.patch
Thanks Olivier! Merged as https://git.xfce.org/apps/xfce4-terminal/commit/?id=61cdb39a75948ae50f6ed59b9b9f492ebdfd5bda Am I understanding correctly that GTK 3.16 is still suffering? It's a shame that the same code behaves differently on each next GTK release.
(In reply to Igor from comment #21) > Thanks Olivier! Merged as > https://git.xfce.org/apps/xfce4-terminal/commit/ > ?id=61cdb39a75948ae50f6ed59b9b9f492ebdfd5bda > > Am I understanding correctly that GTK 3.16 is still suffering? It's a shame > that the same code behaves differently on each next GTK release. What remains is GTK+ 3.16.7 build with the vertical shrinkage issue. GTK+ 3.14.13 (CentOS 7) build works OK gtk3-3.14.13-16.el7.x86_64 vte291-0.38.3-2.el7.x86_64 gnome-terminal-3.14.3-3.el7_2.1.x86_64 xfce4-terminal-0.7.0-104.20160731git6f135b1.el7.centos.x86_64
At least as far as Fedora, this is no longer an issue. GTK+ 3.16.7 is EOL, altogether with Fedora 22. Until someone eventually offer solution, feel free to close this report.
Ok, thanks. Fixed for actual GTK versions.