Created attachment 6703 Gentoo build log As reported in the linked Gentoo bug, attempting to build with --disable-gtk3 and no GTK+3 installed results in dependency errors + include errors: make[2]: *** No rule to make target '../libxfce4ui/libxfce4ui-2.la', needed by 'test-ui-gtk3'. Stop. make[2]: *** Waiting for unfinished jobs.... test-ui.c:28:21: fatal error: gtk/gtk.h: No such file or directory #include <gtk/gtk.h> ^ compilation terminated. Makefile:571: recipe for target 'test_ui_gtk3-test-ui.o' failed
Ping. Could you let me know if non-GTK+3 builds are still considered supported? I can write a patch for this, however I don't see much of a point if the next release is going to drop support for this.
At least some core components (I just had a quick look and for example xfce4-session is one of them) will be Gtk3-only in the 4.14 release (for which 4.13, which you are trying to compile, is the development version). Therefore you shouldn't use the --disable-gtk3 flag for these versions. And in my opinion this option should be removed for 4.14. However, from what I see this bug already existed in 4.12. And the 4.12 can be used gtk2-only. So at least for this branch a patch is needed.
Created attachment 6812 patch Please test if this patch solves the compiling issue.
(In reply to flo.xfce from comment #2) > At least some core components (I just had a quick look and for example > xfce4-session is one of them) will be Gtk3-only in the 4.14 release (for > which 4.13, which you are trying to compile, is the development version). > Therefore you shouldn't use the --disable-gtk3 flag for these versions. And > in my opinion this option should be removed for 4.14. Well, I'm entirely happy with confirmation that GTK+2-only variant is not supported and people can't bother me about it. > However, from what I see this bug already existed in 4.12. And the 4.12 can > be used gtk2-only. So at least for this branch a patch is needed. Hmm, are you sure? I'm looking at 4.12.1, and I don't see the relevant files, or any failure there. (In reply to flo.xfce from comment #3) > Created attachment 6812 > patch > > Please test if this patch solves the compiling issue. In any case, this patch fixes the issue for me.
The patch looks good, I've applied and pushed it to master. https://git.xfce.org/xfce/libxfce4ui/commit/?id=bd55a3cee960255aa59a331ee2998c01fdfff8eb @Flo: Please submit a git patch next time, it makes our lives a lot easier!