! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Clicking the location pathbar (buttons) background should temporarily switch ...
Status:
RESOLVED: FIXED
Severity:
enhancement

Comments

Description Chris 2016-05-15 02:51:24 CEST
I took a dive into the code to see how hard this would be. So here's some notes.

If the container can handle the click event, then it 50% easier, because otherwise you have to figure out the positioning since the child widgets are manually positioned.


thunar-window.c
	Probably needs a function similar to the "view-location-selector-toolbar" action handler that changes to the texfield but doesn't update gtk's config. This is needed so that when we lose focus of the textfield, we can tell if we need to change back to buttons or not.

	"view-location-selector-pathbar"
		action to change to the location buttons
	"view-location-selector-toolbar"
		action to change to the location textfield

thunar-location-entry.c
	Needs to handle whatever the GTK loseFocus/blur event is to switch back to the buttons. This can simply call the "view-location-selector-pathbar" action handler.

thunar-location-buttons.c
	Needs a button to call the "view-location-selector-toolbar" action (or our new action/function that doesn't update the config).
	If we can "click" the background, this will be really easy, so long as the child buttons of the container block the click event from bubbling.
	If not, we need a new button between the last button and the "scroll" button called buttons->right_slider.
		Note that buttons can be RTL or LTR
		Copy the buttons->right_slider code.
		LTR
			x1 is 
			x2 is right_slider_offset
		RTL
			x1 is right_slider_offset + buttons->slider_width
			x2 is
		and (child_allocation.x = right_slider_offset + allocation->x;) is probably needed too to draw properly (allocation->x is the container's offset).



	thunar_location_buttons_size_allocate(...)
		this is where the button's are positioned and the slider buttons are toggled on/off
		this is where we would need to resize the button that calls "view-location-selector-toolbar"
Comment 1 alexxcons editbugs 2017-09-17 23:31:01 CEST
Fixed on master in commit fc53ebd55aac4e080a3a948f84847b9cb0d5201d
   Rework how location bar selection works

   ThunarLocationBar now isn't an interface, but an actual widget hosting the
   different location bars. Unfortunately, there is still some code left in
   ThunarWindow, but this is expected to go away when GtkAction finally dies.

   On the plus side, we got rid of GtkUIManager inside the location bars
   and also nuked ThunarLocationDialog from orbit.

and later further improved by the following commits:
 
677755d4acec37e83b15aa94b3848e7464105e14:
   Add edit icon to location bar filler

   Also removing the entry style from it.
   With the icon it makes more sense behave as button.

67eabbe456330efe0296c16c087af4efa8fea468
   Fixed critical msg when clicked on pathbar filler

c6c68336332d7b04d9e5b3ea472fc61bc5db801f
   Refactored "thunar_location_buttons_size_allocate"

   Getting rid of warnings and to introduce a minimum
   size for the edit-button

To be released in 1.7.0  Bug can be closed.
Comment 2 Andre Miranda editbugs 2017-09-18 00:35:56 CEST
Closing...

Bug #12578

Reported by:
Chris
Reported on: 2016-05-15
Last modified on: 2017-09-18

People

Assignee:
Xfce Bug Triage
CC List:
5 users

Version

Version:
1.6.12

Attachments

Additional information