! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Close Tab keyboard shortcut doesn't work if the only tab is open
Status:
RESOLVED: FIXED
Priority:
Very High
Product:
Xfce4-terminal
Component:
General

Comments

Description Anonymous 2016-03-11 22:38:14 CET
This is a bug since you have to memorize and use two shortcuts while in most other applications (not limited to Konsole - KDE terminal, Mozilla Firefox, Google Chrome and Internet Explorer, etc.) the last tab closes the entire application.

It's a major usability issue, so I'm marking this bug report as such.

Best regards,

Artem S. Tashkinov
Comment 1 Anonymous 2016-03-11 22:40:48 CET
This patch unfortunately doesn't work:

--- xfce4-terminal-0.6.3/terminal/terminal-window.c
+++ xfce4-terminal-0.6.3-last-tab-close/terminal/terminal-window.c
@@ -672,7 +672,7 @@
   gtk_action_set_sensitive (window->action_detah_tab, (n_pages > 1));
 
   /* ... same for the "Close Tab" action */
-  gtk_action_set_sensitive (window->action_close_tab, (n_pages > 1));
+  gtk_action_set_sensitive (window->action_close_tab, TRUE);
 
   /* update the actions for the current terminal screen */
  if (G_LIKELY (window->active != NULL))

Perhaps some internal GTK code has to be adjusted but I'm not a programmer.
Comment 2 Igor editbugs 2016-06-16 17:35:55 CEST
Fixed in the git version.

Bug #12490

Reported by:
Anonymous
Reported on: 2016-03-11
Last modified on: 2016-06-17

People

CC List:
2 users

Version

Version:
unspecified

Attachments

Additional information