12490 – Close Tab keyboard shortcut doesn't work if the only tab is open

Close Tab keyboard shortcut doesn't work if the only tab is open

Status:

RESOLVED: FIXED

Priority:
Very High

Severity:
major

Product:
Xfce4-terminal

Component:

General

Comments

Description Anonymous 2016-03-11 22:38:14 CET

This is a bug since you have to memorize and use two shortcuts while in most other applications (not limited to Konsole - KDE terminal, Mozilla Firefox, Google Chrome and Internet Explorer, etc.) the last tab closes the entire application.

It's a major usability issue, so I'm marking this bug report as such.

Best regards,

Artem S. Tashkinov

Comment 1 Anonymous 2016-03-11 22:40:48 CET

This patch unfortunately doesn't work:

--- xfce4-terminal-0.6.3/terminal/terminal-window.c
+++ xfce4-terminal-0.6.3-last-tab-close/terminal/terminal-window.c
@@ -672,7 +672,7 @@
   gtk_action_set_sensitive (window->action_detah_tab, (n_pages > 1));
 
   /* ... same for the "Close Tab" action */
-  gtk_action_set_sensitive (window->action_close_tab, (n_pages > 1));
+  gtk_action_set_sensitive (window->action_close_tab, TRUE);
 
   /* update the actions for the current terminal screen */
  if (G_LIKELY (window->active != NULL))

Perhaps some internal GTK code has to be adjusted but I'm not a programmer.

Comment 2 Igor editbugs

2016-06-16 17:35:55 CEST

Fixed in the git version.

Comment 3 Igor editbugs

2016-06-17 16:25:59 CEST

http://git.xfce.org/apps/xfce4-terminal/commit/?id=356c4881796a5edc0d01b2827af7211c74e64a8e

Comments

Bug #12490

People

Version

Attachments

Additional information